Merge up to 133dd9d669e5b8beb7c7787b0be677621808e72d from upstream #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for code coverage collection. This helps developers to check if their test scenarios really exercised all the OpenOCD functionality that they intended to test. - Option --enable-gcov has been added to configure.ac which enables the coverage collection using Gcov. (Disabled by default.) - The steps to collect and inspect the coverage have been described in HACKING file. Change-Id: I259e401937a255e7ad7f155359a0b7787e4d0752 Signed-off-by: Jan Matyas <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8521 Tested-by: jenkins Reviewed-by: Evgeniy Naydanov <[email protected]> Reviewed-by: Antonio Borneo <[email protected]>
git log is faster than git2cl and the result has a better format. Change-Id: I465ca62e3e30fed230fe9661e82a987980c05459 Signed-off-by: R. Diez <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8531 Tested-by: jenkins Reviewed-by: R. Diez <[email protected]> Reviewed-by: Antonio Borneo <[email protected]>
Change-Id: I67cc22752b34dd49c277e247f0b648047927a02b Signed-off-by: R. Diez <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8532 Reviewed-by: R. Diez <[email protected]> Tested-by: jenkins Reviewed-by: zapb <[email protected]> Reviewed-by: Antonio Borneo <[email protected]>
Checkpatch rejects patches that have empty commit description and logs them with: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one But if the patch has a gerrit's Change-Id line placed before the line Signed-off-by, then checkpatch considers the Change-Id line as a valid commit description text. Use the Change-Id tag as a marker of the end of the commit message, thus not counting its line as part of the commit description. This patch is not relevant for the Linux kernel development process as gerrit is not involved and the Change-Id tag is rejected. But other projects, like OpenOCD, base the development on gerrit and reuse kernel's checkpatch with flag '--ignore GERRIT_CHANGE_ID'. This patch has been refused [1] in Linux upstream because it has not been considered relevant for that project. Let's take it as another add-on in OpenOCD checkpatch. Change-Id: I3b55b8fffa07ce67177c108e7c9554ca46674246 Signed-off-by: Antonio Borneo <[email protected]> Link: [1] https://lore.kernel.org/lkml/[email protected]/ Reviewed-on: https://review.openocd.org/c/openocd/+/8539 Tested-by: jenkins
With the drop of the code for the probe zy1000 [1] and then the drop of minidriver code [2], there are no more auto-generated source files. Remove them from the list of generated files to be ignored. Change-Id: Iee65e21528674ea4cc94018e52126f882da4f07c Signed-off-by: Antonio Borneo <[email protected]> [1] b0fe92d ("zy1000: drop the code, deprecated in v0.10.0") [2] 25218e8 ("jtag: remove minidriver code and minidriver-dummy") Reviewed-on: https://review.openocd.org/c/openocd/+/8522 Tested-by: jenkins
The function is not referenced outside the file. Make it static. Change-Id: I72e96624749ae4cc7f4566d737a88186e899616a Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8541 Tested-by: jenkins
The functions: - jtag_error_clear(); - jtag_tap_count(); are not referenced outside the file. Make them static. Change-Id: I00fcf06b1838b9f6c955c19772f1d41d486459e9 Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8542 Tested-by: jenkins
The functions: - interface_jtag_add_callback(); - interface_jtag_add_callback4(); are not referenced outside the file. Make them static. Change-Id: I84f738309d23c8d0b5329aa04436db750cf185e5 Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8543 Tested-by: jenkins
The functions: - mpsse_divide_by_5_config(); - mpsse_purge(); - mpsse_rtck_config(); - mpsse_set_divisor(); are not referenced outside the file. Make them static. Change-Id: Id6930183a3ce26693b2113f622046168ba289df8 Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8544 Tested-by: jenkins
The function is not used. Drop it! Change-Id: I176c9d6ba077e36b762c14f9b877d5152992763c Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8545 Tested-by: jenkins Reviewed-by: zapb <[email protected]>
The function is not referenced outside the file. Make it static. Change-Id: I5f2a2c70085b9158df8806432bb9ed09bb256ab5 Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8546 Tested-by: jenkins
The function is not referenced outside the file. Make it static. Change-Id: Ifeccc5e38f3da4b4111422860bc1c1447d00f7fe Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8547 Tested-by: jenkins
The function is not referenced outside the file. Make it static. Change-Id: Ic2552c040b6b46c0334851a4fc0fdaa400e11e4c Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8548 Tested-by: jenkins
The function is not used. Drop it! Change-Id: I1625e03714b5a842f668098191c39cce34f815e8 Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8549 Tested-by: jenkins
The function esirisc_jtag_get_eid() is not used outside the file. Make it static. The function esirisc_jtag_disable_debug() is never used. Make it static and mark it as unused. Change-Id: I5c99cbf77cc9c527b6e18a3f67caa24f8551d09c Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8550 Tested-by: jenkins
The functions: - semihosting_opcode_to_str(); - semihosting_write_fields(); - semihosting_set_field(); are not referenced outside the file. Make them static. Change-Id: Ia8d35554673145fdfe0e501543eb18919863039f Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8551 Tested-by: jenkins
Change the variable name to 'is_configure' to be compatible with the coding style and use 'bool' as data type. Change-Id: I8609f9807c8bd14eaf6c93acf63fd51b55c9bbbb Signed-off-by: Marc Schink <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8573 Tested-by: jenkins Reviewed-by: Antonio Borneo <[email protected]>
The stlink driver, both in dapdirect and in HLA modes, pretends to store locally the value of the adapter speed in order to use it later-on during adapter initialization. It doesn't work in dapdirect mode since the code to store locally the value will not be executed until the adapter is already fully initialized. This cause an issue in dapdirect mode: - due to the local value, still kept at -1, the adapter will be initialized to the lowest clock speed (5 KHz on stlink v2 in SWD mode); - after the adapter initialization the framework will again set the speed with the value requested by the user. Some target, like nRF51822, only accepts JTAG/SWD speed in a defined range of frequencies. The initial speed of 5 KHz used by dapdirect can be out of range, making the target debug port not working. The adapter framework already stores the value of speed and makes it available through adapter_get_speed_khz(). Drop struct hl_interface_param::initial_interface_speed. Let the code to use adapter_get_speed_khz(). Change-Id: Ie11bf0234574f2a9180d3d3a16efb78e08dfcd86 Reported-by: Andrzej Sierżęga <[email protected]> Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8574 Reviewed-by: Andrzej Sierżęga <[email protected]> Tested-by: jenkins
Also convert the Bus Pirate to the common PROCESS_ADAPTERS logic. Change-Id: Ifa8ebcee380c16d7e308ba7a75dbffdb74208285 Signed-off-by: R. Diez <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8533 Reviewed-by: Antonio Borneo <[email protected]> Reviewed-by: R. Diez <[email protected]> Tested-by: jenkins
List AC_ARG_ADAPTERS was missing a comma separating two of the elements. Also verify that each adapter is set to either 'auto', 'yes' or 'no', which should prevent such issues from going unnoticed in the future. Change-Id: I0d407e03b1e5a3edc61d7dc93d5ffa70fe079b3c Signed-off-by: R. Diez <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8534 Tested-by: jenkins Reviewed-by: R. Diez <[email protected]> Reviewed-by: Antonio Borneo <[email protected]>
Catch an invalid option like "--enable-buspirate=rubbish". Also mention all valid values in the help text for those options. Change-Id: Ib0fb8904132d07cc5cde421aa816ca6971a08769 Signed-off-by: R. Diez <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8540 Reviewed-by: R. Diez <[email protected]> Reviewed-by: Antonio Borneo <[email protected]> Tested-by: jenkins
Remove the prefix since it is redundant. Change-Id: I9c23c0479ba40be24e471309e720060cd03763ee Signed-off-by: Marc Schink <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8577 Tested-by: jenkins Reviewed-by: Ian Thompson <[email protected]> Reviewed-by: Antonio Borneo <[email protected]>
Remove the prefix since it is redundant. While at it, also get rid of the useless exclamation mark. Change-Id: I8707342c602cea735c5a423b37ebe40a3aafb137 Signed-off-by: Marc Schink <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8578 Tested-by: jenkins Reviewed-by: Antonio Borneo <[email protected]>
Use LOG_TARGET_xxx() for the remaining log messages. Change-Id: I4b86b206d17dead0662388e827204b40a7d29edd Signed-off-by: Marc Schink <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8579 Tested-by: jenkins Reviewed-by: Antonio Borneo <[email protected]>
Use LOG_TARGET_xxx() for the remaining log messages. Change-Id: If52e3935b57e4c39212ce6b5111ff65159de1373 Signed-off-by: Marc Schink <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8580 Tested-by: jenkins Reviewed-by: Antonio Borneo <[email protected]>
Add maskisr command support to Xtensa NX targets allowing masking of interrupts during single stepping. Change-Id: I3835479de8015f1a2842afd1aeab24829e385031 Signed-off-by: Henrik Mau <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8575 Reviewed-by: Ian Thompson <[email protected]> Reviewed-by: Antonio Borneo <[email protected]> Tested-by: jenkins
Change-Id: Iaaf234da839cbed61684f4615135c9a42213c56a
aap-sc
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No merge conflicts