Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target/riscv: new ebreak controls #1168

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from
Open

target/riscv: new ebreak controls #1168

wants to merge 1 commit into from

Conversation

en-sc
Copy link
Collaborator

@en-sc en-sc commented Nov 14, 2024

  • Deprecate riscv set_ebreak* commands.
  • Introduce RISC-V-sepecific configure parameter -ebreak instead.
  • Separate controls for VS and VU modes.

Change-Id: I0ff88318dcb52af6923eb9f20f9d0c056ad09cf0

@en-sc en-sc force-pushed the en-sc/ebreak branch 2 times, most recently from 6b1faa6 to ccb13a1 Compare November 14, 2024 15:51
@en-sc
Copy link
Collaborator Author

en-sc commented Nov 26, 2024

@JanMatCodasip, @MarekVCodasip ping

JanMatCodasip
JanMatCodasip reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change looks all right - thank you.

I have finished my review and do not expect to have any further comments.

src/target/riscv/riscv.h Outdated Show resolved Hide resolved
src/target/riscv/riscv.h Outdated Show resolved Hide resolved
src/target/riscv/riscv.h Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
en-sc
en-sc commented Dec 9, 2024
View reviewed changes
src/target/riscv/riscv.c Outdated
{
struct riscv_private_config *pc = target->private_config;
if (!pc) {
pc = default_riscv_private_config();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with private_config deallocation in case of an error.
Please, see https://review.openocd.org/c/openocd/+/8637/comments/512687b3_e6274fb6

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by https://review.openocd.org/c/openocd/+/8642

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is somewhat minor and is not specific to this patch.
IMHO, the patch can be merged without the fix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - no problem with merging this now.

@en-sc en-sc requested a review from JanMatCodasip December 11, 2024 16:35
JanMatCodasip
JanMatCodasip reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the suggestions so far.

I have noticed three more items, and shouldn't have more comments than that.

src/target/riscv/riscv-011.c Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
@en-sc
Copy link
Collaborator Author

en-sc commented Dec 16, 2024 •
edited
Loading

Please, note: In the last change I didn't only address review comments.
I've also moved creation of private_config to target create and replaced a pointer to target with a pointer to private_config where applicable.

JanMatCodasip
JanMatCodasip previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

en-sc
en-sc commented Dec 18, 2024
View reviewed changes
src/target/riscv/riscv.c Outdated Show resolved Hide resolved
@en-sc
target/riscv: new ebreak controls
c335219 
* Deprecate `riscv set_ebreak*` commands.
* Introduce RISC-V-sepecific `configure` parameter `-ebreak` instead.
* Separate controls for VS and VU modes.

Change-Id: I0ff88318dcb52af6923eb9f20f9d0c056ad09cf0
Signed-off-by: Evgeniy Naydanov <[email protected]>
@en-sc en-sc requested a review from JanMatCodasip December 20, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekVCodasip MarekVCodasip Awaiting requested review from MarekVCodasip

@JanMatCodasip JanMatCodasip Awaiting requested review from JanMatCodasip

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@en-sc @JanMatCodasip