refactor: switch to react18-json-view
#890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
changed the title
react18-json-view
# Conflicts: # package-lock.json
ckniffen
requested review from
justinr1234,
khancode,
JST5000 and
bugsbunnies
and removed request for
ckniffen
justinr1234
approved these changes
Dec 6, 2023
bugsbunnies
approved these changes
Dec 7, 2023
mvadari
commented
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR replaces
react-json-viewwithreact18-json-view. This results in 18 less dependencies and a 2kb smaller gzipped bundle.There were a few small tweaks to the json view themes to use the closest color within the sites color palette (previously they were one offs) and margins/padding.
Context of Change
react-json-viewdoesn't work with React 18 and is also much bigger thanreact18-json-view. Related to #668.mac-s-g/react-json-view#441
Type of Change
TypeScript/Hooks Update
N/A
Before / After
Before:
After:
Test Plan
Works locally. Passes CI.