-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't support React 18? #441
Comments
same here |
It working via |
a better solution is to override this in package.json {
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-json-view": "^1.21.3"
},
"overrides": {
"react-json-view": {
"react": "$react",
"react-dom": "$react-dom"
}
}
} |
This is not working for me. I am still getting the same error. |
did you update your version of |
Hey thanks, I was on v8.1 |
Unfortunately, this doesn't work if |
I also couldn't fix with --legacy-peer-deps. |
+1 |
1 similar comment
+1 |
Hey there! You might want to give this one a try: https://github.com/YYsuni/react18-json-view |
Github: https://github.com/uiwjs/react-json-view Size and dependenciesHere is the size benchmark (using bundlephobia.com) against similar React libraries (found by |
Look, I have added an editable feature and updated icons. Please feel free to submit an issue if you encounter any problems. |
@Dilven Thank you very much for sharing this solution. Saved my deploy from a frontend competition 😅 |
This PR replaces `react-json-view` with `react18-json-view`. This results in 18 less dependencies and a 2kb smaller gzipped bundle. There were a few small tweaks to the json view themes to use the closest color within the sites color palette (previously they were one offs) and margins/padding. ### Context of Change `react-json-view` doesn't work with React 18 and is also much bigger than `react18-json-view`. Related to #668. mac-s-g/react-json-view#441 Co-authored-by: Caleb Kniffen <[email protected]>
I tried to install the library in one of my applications, which runs on react 18. But i got the following error -
Does it not support React 18?
The text was updated successfully, but these errors were encountered: