Skip to content

Commit

Permalink
spanconfigreconcilerccl: Use deterministic descriptor ID generation f…
Browse files Browse the repository at this point in the history
…or test

This PR updates the spanconfigreconciler data driven test
to use transactional descriptor ID generation
(cockroachdb#85444) to generate
deterministic descriptor IDs. This will help avoid test flakes around
changing descriptor IDs due to transaction retries etc.

Epic: none
Fixes: cockroachdb#122343
Release note: None
  • Loading branch information
rimadeodhar committed Apr 17, 2024
1 parent 0ac28a3 commit 1e27b66
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ package spanconfigreconcilerccl
import (
"context"
"fmt"
"github.com/cockroachdb/cockroach/pkg/sql"
"sort"
"testing"
"time"
Expand Down Expand Up @@ -106,6 +107,9 @@ func TestDataDriven(t *testing.T) {
Knobs: base.TestingKnobs{
JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(), // speeds up test
SpanConfig: scKnobs,
SQLExecutor: &sql.ExecutorTestingKnobs{
UseTransactionalDescIDGenerator: true,
},
},
},
})
Expand Down

0 comments on commit 1e27b66

Please sign in to comment.