logictest: use deterministic ID generation in tenants #85444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#85366, we introduced a mechanism to make descriptor ID generation transactional and, in the absence of parallelism, deterministic. That PR failed to set the knob for secondary tenant configurations. This commit rectifies that oversight. This should allow us to avoid flakes like: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_GitHubCiOptional/5939930?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true Release note: None
|
This change is |
|
TFTR! bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
rimadeodhar
added a commit
to rimadeodhar/cockroach
that referenced
this pull request
Apr 17, 2024
…or test This PR updates the spanconfigreconciler data driven test to use transactional descriptor ID generation (cockroachdb#85444) to generate deterministic descriptor IDs. This will help avoid test flakes around changing descriptor IDs due to transaction retries etc. Epic: none Fixes: cockroachdb#122343 Release note: None
rimadeodhar
added a commit
to rimadeodhar/cockroach
that referenced
this pull request
Apr 19, 2024
…or test This PR updates the spanconfigreconciler data driven test to use transactional descriptor ID generation (cockroachdb#85444) to generate deterministic descriptor IDs. This will help avoid test flakes around changing descriptor IDs due to transaction retries etc. Epic: none Fixes: cockroachdb#122343 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #85366, we introduced a mechanism to make descriptor ID generation
transactional and, in the absence of parallelism, deterministic. That PR
failed to set the knob for secondary tenant configurations. This commit
rectifies that oversight.
This should allow us to avoid flakes like:
https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_GitHubCiOptional/5939930?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true
Release note: None