Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORE documentation says source can be constant value #815

Closed
notmgsk opened this issue Mar 1, 2019 · 1 comment · Fixed by #1010
Closed

STORE documentation says source can be constant value #815

notmgsk opened this issue Mar 1, 2019 · 1 comment · Fixed by #1010
Assignees
@appleby
Labels
bug 🐛 An issue that needs fixing.
Milestone
v2.12

Comments

@notmgsk
Copy link
Contributor

notmgsk commented Mar 1, 2019

But actually it type errors if source is not a MemoryReference.
@ecpeterson
Copy link
Contributor

Oof. The documentation is correct: what can't be constant is the array index.

@notmgsk notmgsk mentioned this issue Sep 16, 2019
Merged
14 tasks
appleby added a commit that referenced this issue Sep 17, 2019
@appleby
Resolve remaining TODO comments in source
68a8774 
- Replace GateParameter with ParameterDesignator everywhere

- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

Fixes #815
@appleby appleby mentioned this issue Sep 18, 2019
Closed
appleby added a commit that referenced this issue Sep 21, 2019
@appleby
Fix operand types for STORE and classical comparison operators
8b0f5e2 
- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

- Allow CONVERT to take any valid memory reference designator, i.e. a
MemoryReference, a string, or a tuple of (str, int).

Fixes #815
@appleby appleby mentioned this issue Sep 21, 2019
Merged
8 tasks
appleby added a commit that referenced this issue Sep 21, 2019
@appleby
Fix operand types for STORE and classical comparison operators
b4bd78e 
- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

- Allow CONVERT to take any valid memory reference designator, i.e. a
MemoryReference, a string, or a tuple of (str, int).

Fixes #815
appleby added a commit that referenced this issue Sep 21, 2019
@appleby
Fix operand types for STORE and classical comparison operators
725782a 
- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

- Allow CONVERT to take any valid memory reference designator, i.e. a
MemoryReference, a string, or a tuple of (str, int).

Fixes #815
@karalekas karalekas added this to the v2.12 milestone Sep 21, 2019
@karalekas karalekas added the bug 🐛 An issue that needs fixing. label Sep 21, 2019
appleby added a commit that referenced this issue Sep 23, 2019
@appleby
Resolve remaining TODO comments in source
a9898e3 
- Replace GateParameter with ParameterDesignator everywhere

- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

Fixes #815
appleby added a commit that referenced this issue Oct 9, 2019
@appleby
Resolve remaining TODO comments in source
697587c 
- Replace GateParameter with ParameterDesignator everywhere

- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

Fixes #815
appleby added a commit that referenced this issue Oct 30, 2019
@appleby
Resolve remaining TODO comments in source
e63f0fe 
- Replace GateParameter with ParameterDesignator everywhere

- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

Fixes #815
appleby added a commit that referenced this issue Oct 30, 2019
@appleby
Resolve remaining TODO comments in source
1aa3649 
- Replace GateParameter with ParameterDesignator everywhere

- Allow immediate floats as third arg in prepare_ternary_operands

- Allow immediate values as source arg for STORE and ClassicalStore

Fixes #815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleby appleby

Labels
bug 🐛 An issue that needs fixing.
Projects
None yet
Milestone
v2.12
Development

Successfully merging a pull request may close this issue.

Fix operand types for STORE and comparison instructions rigetti/pyquil
4 participants
@appleby @karalekas @notmgsk @ecpeterson