Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORE instruction should accept constant value for source argument #425

Closed
appleby opened this issue Sep 18, 2019 · 0 comments · Fixed by #428
Closed

STORE instruction should accept constant value for source argument #425

appleby opened this issue Sep 18, 2019 · 0 comments · Fixed by #428

Comments

@appleby
Copy link
Contributor

appleby commented Sep 18, 2019

The Quil spec says the source argument to a STORE instruction can be an immediate int or real in addition to a memory reference, but quilc rejects it. For example:

$ echo "DECLARE rr REAL; DECLARE ri INTEGER; STORE rr ri 1.0" | ./quilc
! ! ! Error: At line 1: Expected an address, got :COMPLEX
$ echo "DECLARE ri INTEGER; STORE ri ri 1" | ./quilc
! ! ! Error: At line 1: Expected an address, got :INTEGER

There is a similar pyquil issue open here: rigetti/pyquil#815

And related PR discussion here and there.

And a tangentially-related issue regarding DEFCIRCUIT: #25
@appleby appleby mentioned this issue Sep 18, 2019
Merged
14 tasks
appleby added a commit that referenced this issue Sep 19, 2019
@appleby
Update parsing of STORE instruction to conform to Quil spec
ea1a805 
According to the Quil spec, STORE's second argument must be a
reference to an int, and it's third argument can be either a memory
reference or an immediate value.

Fixes #425
appleby added a commit that referenced this issue Sep 19, 2019
@appleby
Update parsing of STORE instruction to conform to Quil spec
0d084f3 
According to the Quil spec, STORE's second argument must be a
reference to an int, and its third argument can be either a memory
reference or an immediate value.

Fixes #425
appleby added a commit that referenced this issue Sep 19, 2019
@appleby
Update parsing of STORE instruction to conform to Quil spec
a277f48 
According to the Quil spec, STORE's second argument must be a
reference to an int, and its third argument can be either a memory
reference or an immediate value.

Fixes #425
@appleby appleby mentioned this issue Sep 19, 2019
Merged
stylewarning pushed a commit that referenced this issue Sep 19, 2019
@appleby @stylewarning
Update parsing of STORE instruction to conform to Quil spec
da305dc 
According to the Quil spec, STORE's second argument must be a
reference to an int, and its third argument can be either a memory
reference or an immediate value.

Fixes #425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update parsing of STORE instruction to conform to Quil spec quil-lang/quilc
1 participant
@appleby