Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to v0.8.0 #141

Merged
merged 2 commits into from
Sep 13, 2023
Merged

bump to v0.8.0 #141

merged 2 commits into from
Sep 13, 2023

Conversation

rhysnewell
Copy link
Owner

I think we've had a lot of movement recent which is probably due for a version bump.
Thinking there have been enough changes that make it no longer in the realm of v0.7.X as many of them would result in compatibility issues.

Otherwise, I can delete this and just change it to v0.7.4

@rhysnewell rhysnewell requested review from wwood and AroneyS September 13, 2023 04:24
@AroneyS
Copy link
Collaborator

AroneyS commented Sep 13, 2023

#127 - fix skip-abundances
#129 - better snakemake cluster support
#131 - update snakemake version
#132 - temp for long-read qc
#139 - read qc improvements

I think a v0.8.0 is warranted. The snakemake resources does change threads for many rules and adds rerun-triggers mtime by default.

@rhysnewell
Copy link
Owner Author

I'll add a fix to those unit tests in this PR, hold up

@rhysnewell
Copy link
Owner Author

@AroneyS, I don't know if you want to double check the tests on your end

@AroneyS
Copy link
Collaborator

AroneyS commented Sep 13, 2023

Yep. Running test_long_read_recovery now. Takes ~40mins for me.

Copy link
Collaborator

@AroneyS AroneyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_long_read_recovery passes

@rhysnewell rhysnewell merged commit 2c61ba1 into dev Sep 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants