Make long read qc temp #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an issue with using temp for the bam files right? What was that again? |
|
I can't exactly remember but I think they were just getting deleted prematurely if the pipeline crashed, or they aren't picked up as a requirement correctly for certain rules so they would get deleted early. They currently just get cleaned up at the end of the pipeline but the final binning rule |
AroneyS
approved these changes
Sep 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cost to storage is not worth having an extra copy of your nanopore reads sitting around just to save time during the QC stage. If users are unaware that they can delete this file then we'll quickly be filling up peoples servers with junk.