Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singlem threads and 16 #178

Closed
wwood opened this issue Dec 1, 2023 · 2 comments
Closed

singlem threads and 16 #178

wwood opened this issue Dec 1, 2023 · 2 comments

Comments

@wwood
Copy link
Collaborator

wwood commented Dec 1, 2023

Hey,

On a large-ish metagenome (~20Gbp) singlem_pipe_reads timed out in the queue. Since singlem pipe can make use of >1 thread (though tbf, improvements could be made), how come it is restricted to 1 thread?

Also, how come the binning methods are set to a maximum of 16 threads with e.g.

    threads:
        min(config["max_threads"], 16)

? If -t is >16, why not use more?

@rhysnewell
Copy link
Owner

I believe this was implemented to try and get the binners and assemblers to run in parallel, but I agree 16 threads is not enough. Probably just best to leave it out how it originally was and let them use max threads instead.

I'll look into the singlem pipe reads threading issue

@wwood
Copy link
Collaborator Author

wwood commented Dec 4, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants