Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threading issues and rosella version #179

Merged
merged 3 commits into from
Dec 6, 2023
Merged

threading issues and rosella version #179

merged 3 commits into from
Dec 6, 2023

Conversation

rhysnewell
Copy link
Owner

@rhysnewell rhysnewell commented Dec 4, 2023 •
edited
Loading

fixes #174, #175

@rhysnewell rhysnewell requested a review from wwood December 4, 2023 02:09
@rhysnewell rhysnewell changed the title fix: remove restrains on many processes and add threads to single pip… threading issues and rosella version Dec 5, 2023
@rhysnewell rhysnewell changed the base branch from main to dev December 5, 2023 00:19
@rhysnewell rhysnewell requested a review from AroneyS December 5, 2023 23:28
@AroneyS
Copy link
Collaborator

AroneyS commented Dec 6, 2023

fixes #178

wwood
wwood approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@wwood wwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. @AroneyS does SingleM appraise use multiple threads? If not maybe set to 1

@AroneyS
Copy link
Collaborator

AroneyS commented Dec 6, 2023

Sounds good to me. @AroneyS does SingleM appraise use multiple threads? If not maybe set to 1

I don't think it does atm

@rhysnewell rhysnewell merged commit 16e1c3e into dev Dec 6, 2023
2 checks passed
@rhysnewell rhysnewell deleted the ISS-174 branch December 6, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AroneyS AroneyS AroneyS left review comments

@wwood wwood wwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhysnewell @AroneyS @wwood