Add host with ipv6 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reverts: #62, reason in commit msg |
Current coverage is 74.75% (diff: 90.00%)@@ master #75 diff @@
==========================================
Files 16 16
Lines 1438 1454 +16
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1067 1087 +20
+ Misses 371 367 -4
Partials 0 0
|
|
Looks good to me 👍 @myakove can you take a look at it? |
myakove
reviewed
Oct 12, 2016
| :return: IP or None | ||
| :rtype: string or None | ||
| """ | ||
| out = self._cmd(["ip", "addr", "show", interface]) |
There was a problem hiding this comment.
You can use -6 here too
ip -6 addr show
| default_gw = re.findall( | ||
| r'(?<=\s)[0-9a-fA-F:]{3,}(?=\s)', i | ||
| ) | ||
| if netaddr.valid_ipv6(default_gw[0]): |
There was a problem hiding this comment.
Do you need this check since we get the IP from ip -6 command?
There was a problem hiding this comment.
I would prefer to keep it there, if the regex fails to match the address correctly.
myakove
approved these changes
Oct 13, 2016
You can add host using ipv6 Always try to resolve FQDN. Before if you created host with domain name but not fully qualified it was stored as fqdn Add ability to find default ipv6 for gateway. Add ability to find ipv6 by interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can add host using ipv6
Always try to resolve FQDN. Before if you created host
with domain name but not fully qualified it was stored
as fqdn
Add ability to find default ipv6 for gateway.
Add ability to find ipv6 by interface
fixes: #56