Fix when FQDN is not resolved by socket.getfqdn(ip) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometime socket.getfqdn(ip) return IP and not the host FQDN so if Host was created with FQDN we will use it as FQDN
Sometime socket.getfqdn(ip) return IP and not the host FQDN so if Host was created with FQDN we will use it as FQDN
Current coverage is 71.88%@@ master #62 diff @@
==========================================
Files 16 16
Lines 1271 1273 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 914 915 +1
- Misses 357 358 +1
Partials 0 0
|
| @@ -59,7 +59,9 @@ def __init__(self, ip, service_provider=None): | |||
| :type service_provider: class which implement SystemService interface | |||
| """ | |||
| super(Host, self).__init__() | |||
| self.h_fqdn = None | |||
There was a problem hiding this comment.
I would leave it as self._fqdn
|
Please cover that new branches with test |
Sometime socket.getfqdn(ip) return IP and not the host FQDN so if Host was created with FQDN we will use it as FQDN
Sometime socket.getfqdn(ip) return IP and not the host FQDN so if Host was created with FQDN we will use it as FQDN
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases socket.getfqdn(ip) return IP and not the host FQDN so if Host
was created with FQDN we will use it as FQDN