Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fail-on-error #64

Closed
wants to merge 4 commits into from
Closed

Conversation

wusatosi
Copy link

This pr deprecates fail-on-error and replace them with -fail-level=error.

Would be happy to implement -fail-level in another pr, but needs more directions on design and documentation.

@massongit
Copy link
Contributor

Would be happy to implement -fail-level in another pr, but needs more directions on design and documentation.

Is reviewdog/action-rubocop#124 helpful?

@mongolyy
Copy link
Contributor

mongolyy commented Jan 8, 2025

@wusatosi

Thank you for the wonderful PR.

Would be happy to implement -fail-level in another pr

I want to support for -fail-level flag.
It seemed that progress was not being made, so I created #67.

If you plan to proceed with this PR, please let me know. I will close my PR accordingly.

@wusatosi
Copy link
Author

Hey thanks for the review.

Sorry I must have missed the comment.

Just note that I did not test run this code because I honestly don't know how to test stuff like this. I am also not good at bash scripts. So maybe extra attention is needed to double check I did everything right.

@mongolyy
Copy link
Contributor

@wusatosi
Thank you for your contribution!

I'm sorry.
I responded to it in #67, because we want to support for -fail-level flag too.

I think this pull request is no longer necessary.

@wusatosi
Copy link
Author

PR is surpassed by #67 .

@wusatosi wusatosi closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants