We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail_on_error
-fail-on-error is deprecated. https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md#rotating_light-deprecation-warnings
-fail-on-error
However, this workflow depends on reviewdog/action-suggester, which does not support -fail-level.
-fail-level
Until the action-suggester is improved, I focus on backward compatibility and set the default value to -fail-on-error at #80.
Once the action-suggester is improved, we will delete the default value. Related to: reviewdog/action-suggester#64
The text was updated successfully, but these errors were encountered:
fail_level
I think it's better not to delete the default value(false) of fail_on_error.
For two reasons
So, I modify some comments using other workflows as a reference.
Sorry, something went wrong.
mongolyy
Successfully merging a pull request may close this issue.
-fail-on-error
is deprecated.https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md#rotating_light-deprecation-warnings
However, this workflow depends on reviewdog/action-suggester, which does not support
-fail-level
.Until the action-suggester is improved, I focus on backward compatibility and set the default value to
-fail-on-error
at #80.Once the action-suggester is improved, we will delete the default value.
Related to: reviewdog/action-suggester#64
The text was updated successfully, but these errors were encountered: