Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value at fail_on_error #81

Closed
mongolyy opened this issue Jan 7, 2025 · 1 comment · Fixed by #83
Closed

Remove default value at fail_on_error #81

mongolyy opened this issue Jan 7, 2025 · 1 comment · Fixed by #83
Assignees

Comments

@mongolyy
Copy link
Owner

mongolyy commented Jan 7, 2025

-fail-on-error is deprecated.
https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md#rotating_light-deprecation-warnings

However, this workflow depends on reviewdog/action-suggester, which does not support -fail-level.

Until the action-suggester is improved, I focus on backward compatibility and set the default value to -fail-on-error at #80.

Once the action-suggester is improved, we will delete the default value.
Related to: reviewdog/action-suggester#64

@mongolyy mongolyy self-assigned this Jan 12, 2025
@mongolyy
Copy link
Owner Author

I think it's better not to delete the default value(false) of fail_on_error.

For two reasons

So, I modify some comments using other workflows as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant