chore: Update_Buttons.scss #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed some discrepancies in terms of the naming convention. &.rev-Button--inverted &.rev-Button--secondary were not following the same pattern established in the rest of the file- they were using color variables for background and vice versa. I added several new variables and utilized them in- &.rev-Button--inverted &.rev-Button--secondary - to solve this problem. Originally was tackling issue revelrylabs#395 but realized it was solved and merged after some time- realized the naming conventions were off in the process and wanted to protect the codebase against unexpected behavior / bugs.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: Improved naming conventions scss/components/_Buttons.scss
Changed some discrepancies in terms of the naming convention. &.rev-Button--inverted &.rev-Button--secondary were not following the same pattern established in the rest of the file- they were using color variables for background and vice versa. I added several new variables and utilized them in- &.rev-Button--inverted &.rev-Button--secondary - to solve this problem. Originally was tackling issue #395 but realized it was solved and merged after some time- realized the naming conventions were off in the process and wanted to protect the codebase against unexpected behavior / bugs.
chore:if your change only impacts developers and doesn't need to make a new package versionfix:if you change is a bug fix which all users should receivefeature:if your change adds new features or new componentsBREAKING CHANGE:if you change changing the API or behavior of the library is a way that breaks some projectsFor more details, check out Conventional Commits.