Buttons - Improve Inverted button's hover, focus and active styles #395
Assignees
Comments
blazebarsamian
added
designy
pinned
Ryan-OToole
added a commit
to Ryan-OToole/harmonium
that referenced
this issue
Oct 14, 2020
Changed some discrepancies in terms of the naming convention. &.rev-Button--inverted &.rev-Button--secondary were not following the same pattern established in the rest of the file- they were using color variables for background and vice versa. I added several new variables and utilized them in- &.rev-Button--inverted &.rev-Button--secondary - to solve this problem. Originally was tackling issue revelrylabs#395 but realized it was solved and merged after some time- realized the naming conventions were off in the process and wanted to protect the codebase against unexpected behavior / bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background: inverted buttons need better hover, focus, active styles. Currently they don't change when you hover/ focus on them. makes it confusing like its not clickable
I'm submitting a ...
What is the current behavior?
For .rev-Button--inverted
, the default styles and the:hover,:focus, and:active` styles are both using the same vars to define background and color. Therefore, theres not any changes to the button when it is hovered, on focus or active which makes it look like its not clickable.What is the expected behavior?
When a inverted button is hovered, on focus, or active, there should be a slight but noticeable change to the button.
For feature requests: why should the behavior change?
Because inverted buttons don't look like they're clickable.
Other information (we love stack traces!)
The text was updated successfully, but these errors were encountered: