-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/wunderkind smart tag #184
Open
AhmedLukmanTR
wants to merge
8
commits into
main
Choose a base branch
from
feat/wunderkind-smart-tag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e62fe16
chore: Install dependencies with npm i
AhmedLukmanTR c609095
feat: Add WunderkindAd component to handle ad slot display based on u…
AhmedLukmanTR 7b111af
refactor: Remove unnecessary ad slot display code
AhmedLukmanTR a0f382f
fix: replace svelte:head with programmatic script injection
AhmedLukmanTR cad28f1
feat: Add WunderkindAd component export
AhmedLukmanTR e32b378
fix: Remove unnecessary p letter
AhmedLukmanTR e747a1a
docs: Add WunderkindAd component story docs
AhmedLukmanTR af6a222
docs: Update WunderkindAd component story to include AdScripts
AhmedLukmanTR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<script lang="ts"> | ||
import { Template, Story, Meta } from '@storybook/addon-svelte-csf'; | ||
|
||
// @ts-ignore raw | ||
import adDocs from './stories/docs/wunderkind.md?raw'; | ||
|
||
import AdScripts from './AdScripts.svelte'; | ||
import WunderkindAd from './WunderkindAd.svelte'; | ||
|
||
import { withComponentDocs } from './../../docs/utils/withParams'; | ||
|
||
const meta = { | ||
...withComponentDocs(adDocs), | ||
}; | ||
</script> | ||
|
||
<Meta title="Components/WunderkindAd" component="{WunderkindAd}" {...meta} /> | ||
|
||
<Template> | ||
<div> | ||
<AdScripts /> | ||
<WunderkindAd /> | ||
</div> | ||
</Template> | ||
|
||
<Story name="Default" /> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<script lang="ts"> | ||
import { onMount } from 'svelte'; | ||
|
||
onMount(() => { | ||
// Check user login status | ||
let isLoggedIn = localStorage.getItem('ArcId.USER_PROFILE') !== null; | ||
if (!isLoggedIn) { | ||
const script = document.createElement('script'); | ||
script.textContent = ` | ||
freestar.config.enabled_slots.push({ | ||
placementName: 'reuters_1x1_bouncex', | ||
slotId: 'reuters_1x1_bouncex', | ||
}); | ||
`; | ||
script.setAttribute('data-cfasync', 'false'); | ||
script.type = 'text/javascript'; | ||
document.head.appendChild(script); | ||
} | ||
}); | ||
</script> | ||
|
||
<div id="reuters_1x1_bouncex"></div> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
Add a wunderkind ad to your page. | ||
|
||
> **IMPORTANT!** Make sure ads are only used on dotcom pages, never on embeds. | ||
|
||
```svelte | ||
<!-- +page.svelte --> | ||
<script> | ||
import { AdScripts } from '@reuters-graphics/graphics-components'; | ||
</script> | ||
|
||
<!-- Include AdScripts only ONCE per page for any type of ad --> | ||
<AdScripts /> | ||
``` | ||
|
||
```svelte | ||
<!-- App.svelte --> | ||
<script> | ||
import { WunderkindAd } from '@reuters-graphics/graphics-components'; | ||
|
||
export let embedded = false; | ||
</script> | ||
|
||
<!-- Check if in an embed context! --> | ||
{#if !embedded} | ||
<WunderkindAd /> | ||
{/if} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain if this div displays an ad, how that behaves and how this ad unit interplays with our existing InlineAd component, if at all? E.g., should we prefer this ad unit and fallback to an InlineAd if the user is not logged in? Something else?