-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/wunderkind smart tag #184
base: main
Are you sure you want to change the base?
Conversation
|
let isLoggedIn = localStorage.getItem('ArcId.USER_PROFILE') !== null; | ||
if (!isLoggedIn) { | ||
const script = document.createElement('script'); | ||
script.textContent = `p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the p
here intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, apologies, that was a mistype. I will rectify that.
}); | ||
</script> | ||
|
||
<div id="reuters_1x1_bouncex"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain if this div displays an ad, how that behaves and how this ad unit interplays with our existing InlineAd component, if at all? E.g., should we prefer this ad unit and fallback to an InlineAd if the user is not logged in? Something else?
What's in this pull request
The PR code checks if a user is logged in (by looking for an ArcId user profile in localStorage), and if they are not logged in, it loads a the advertising script specifically for a div with "reuters_1x1_bouncex" id.
Before submitting, please check that you've ...