Fix registry element equality check #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could potentially solve retrooper#962, although I can't reproduce that issue This may be caused by two different changes to packetevents: 1. We did a little memory optimization so only elements different to the vanilly registry get stored 2. We fixed an issue where some elements would not equal the "same" vanilla element This could cause every custom element to just never be registered, so we now do explicit deep-equals checks before saving the vanilla element instead
Caused by me just cherry-picking some commits from another branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from 1.21.2 update branch
See commit description of c9d42f8 for some more detailed info
Fixes #962