World height is wrong on join

[SamB440]

Describe the bug
GrimAnticheat/Grim@1238555

User#getTotalWorldHeight seems to return the overworld value on join. Switching dimensions works as expected, it just seems to be on join.

Software brand
Paper 1.21

Plugins
Grim

How To Reproduce
Enter the nether, disconnect, join again, the world height will be wrong

Expected behavior
World height to return the correct values

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

[SamB440]

Odd, considering InternalPacketListener listens to these

[booky10]

[18:33:42 INFO]: UUID of player booky10 is d20c8b3b-9f9e-48da-94c4-2c614dd76e29
[18:33:42 INFO]: [packetevents] [STDOUT] {JOIN} CHANGED DIMENSION TO minecraft:the_end / TYPE: minecraft:the_end [FROM 0 TO 256]

[18:36:20 INFO]: UUID of player booky10 is d20c8b3b-9f9e-48da-94c4-2c614dd76e29
[18:36:20 INFO]: [packetevents] [STDOUT] {JOIN} CHANGED DIMENSION TO minecraft:the_nether / TYPE: minecraft:the_nether [FROM 0 TO 256]

works for me in both the nether and the end, when adding some log messages and also listening to chunk packets

paper version

This server is running Paper version 1.21.1-52-master@e08e667 (2024-08-26T18:02:06Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.1-26-52ae4ad (MC: 1.21.1)

---

is there some reproduction step or some grim-specific feature missing?
the listeners priorities shouldn't be an issue, grim tracks the dimension type at priority HIGH, while packetevents sets them at priority LOWEST

[SamB440]

Have you tried installing the terralith datapack?

[booky10]

Installing Terralith doesn't change anything in neither the nether nor the end
The datapack also only modifies the overworld, at least the one I downloaded from here

[booky10]

See commit description of booky10@c9d42f8 for a possible cause to this issue
This may be reproducible when modifying world height of the overworld, nether or end, but I didn't test this yet

[SamB440]

It seems to still be happening, I should have mentioned also that I used Paper 1.19.4 to test (idk why I put 1.21)

You should see an error like

[15:44:12 WARN]: [ac.grim.grimac.shaded.com.github.retrooper.packetevents.PacketEventsAPI] PacketEvents caught an unhandled exception while calling your listener.
java.lang.IllegalStateException: null
        at ac.grim.grimac.shaded.com.github.retrooper.packetevents.protocol.stream.NetStreamInput.readUnsignedByte(NetStreamInput.java:62) ~[grimac-2.3.67.jar:?]
        at ac.grim.grimac.shaded.com.github.retrooper.packetevents.protocol.stream.NetStreamInput.readUnsignedShort(NetStreamInput.java:75) ~[grimac-2.3.67.jar:?]
        at ac.grim.grimac.shaded.com.github.retrooper.packetevents.protocol.stream.NetStreamInput.readShort(NetStreamInput.java:70) ~[grimac-2.3.67.jar:?]
        at ac.grim.grimac.shaded.com.github.retrooper.packetevents.protocol.world.chunk.impl.v_1_18.Chunk_v1_18.read(Chunk_v1_18.java:50) ~[grimac-2.3.67.jar:?]
        at ac.grim.grimac.shaded.com.github.retrooper.packetevents.protocol.world.chunk.reader.impl.ChunkReader_v1_18.read(ChunkReader_v1_18.java:35) ~[grimac-2.3.67.jar:?]
        at ac.grim.grimac.events.packets.worldreader.PacketWorldReaderEighteen.handleMapChunk(PacketWorldReaderEighteen.java:27) ~[grimac-2.3.67.jar:?]

When logging into the nether due to the world height being wrong

[SamB440]

Someone reported having world height issues in the nether on 1.21 with this datapack
NWMQXch.zip