New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/implement issue 389 #489

Closed

briemla wants to merge 3 commits into master from feature/implement-issue-389

Contributor

briemla commented Jan 21, 2020 •

edited

Loading

Before submission, please check that ...

the code follows the Clean Code guidelines.
the necessary tests are either created or updated.
all status checks (Travis CI, SonarCloud, etc.) pass.
your commit history is cleaned up.
you updated the changelog.
you updated necessary documentation within retest/docs.

Description

Support more complex CSS selectors when healing tests.

This is a partial implementation of issue #389. It supports all attribute selectors specified at w3schools and the following pseudo class selectors: :checked, :disabled and :read-only

State of this PR

This PR does not support pseudo class selectors except :checked, :disabled and :read-only.

Additional Context

cla-bot bot added the cla-signed label

briemla force-pushed the feature/implement-issue-389 branch from 25a16b7 to 511dd6d Compare

January 21, 2020 18:35

rebazer force-pushed the feature/implement-issue-389 branch 6 times, most recently from df1c0d2 to 5ee1d72 Compare

January 23, 2020 14:53

briemla requested a review from diba1013

January 23, 2020 18:49

rebazer force-pushed the feature/implement-issue-389 branch from 5ee1d72 to 757e7b5 Compare

January 27, 2020 11:01

briemla added 3 commits

January 27, 2020 12:54


          Support More Complex CSS Selectors

8ac17eb

Implement all attribute selectors.
Ensure attribute value is available.
Create predicates for css selectors in separate class.
Configure supported css selectors via regex expression and factory
method.


          Support More Complex CSS Selectors

522a3b6

Support already available pseudo classes.
Ignore not selector.
Verify attribute selectors in integration test.


          Support More Complex CSS Selectors

514f009

Update changelog
Clean up.

rebazer force-pushed the feature/implement-issue-389 branch from 757e7b5 to 514f009 Compare

January 27, 2020 12:54

sonarcloud bot commented Jan 27, 2020

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
7 Code Smells

0.0% Coverage
0.0% Duplication

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

14 similar comments

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

27 similar comments

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Collaborator

rebazer commented Jan 28, 2020

Rebase failed, this pull request needs some manual love ...

Contributor

beatngu13 commented Jan 28, 2020

Will close this to mute rebazer. 😉

beatngu13 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels