Skip to content

Commit

Permalink
Support More Complex CSS Selectors
Browse files Browse the repository at this point in the history
Update changelog
Clean up.
  • Loading branch information
briemla authored and rebazer committed Jan 23, 2020
1 parent 0ed45f2 commit df1c0d2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ Table of Contents

* Provide additional metadata: current URL
* Save the warnings identified by the `UnbreakableDriver` to the report to allow for healing of the test code.
* Implement [#389](https://github.com/retest/recheck-web/issues/389)
* All CSS selectors using attribute syntax are supported.
* The pseudo class selectors: checked, disabled, and read-only are supported.

### Improvements

Expand Down
2 changes: 0 additions & 2 deletions src/main/java/de/retest/web/selenium/css/Has.java
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ private static Predicate<Element> hasAttributeValue( final String attribute, fin
}

private static String clearQuotes( final String result ) {
// TODO check specification
if ( result == null ) {
return "true";
}
Expand Down Expand Up @@ -96,7 +95,6 @@ public static Predicate<Element> cssPseudoClass( final String pseudoClass ) {
}

private static boolean hasPseudoClass( final Element element, final String pseudoClass ) {
// TODO kommt hier immer String oder auch boolean?
return "true".equals( element.getAttributeValue( pseudoClass ) );
}

Expand Down

0 comments on commit df1c0d2

Please sign in to comment.