Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionId as NewType #1483

Merged
merged 5 commits into from
Apr 30, 2024
Merged

PartitionId as NewType #1483

merged 5 commits into from
Apr 30, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Apr 30, 2024 •
edited
Loading

This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

Test Results

 99 files  +4   99 suites  +4   8m 29s ⏱️ +42s
 84 tests +2   82 ✅ +2  2 💤 ±0  0 ❌ ±0 
216 runs  +4  210 ✅ +4  6 💤 ±0  0 ❌ ±0 

Results for commit acb61a4. ± Comparison against base commit 05eb4ba.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman mentioned this pull request Apr 30, 2024
Merged
tillrohrmann
tillrohrmann approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@AhmedSoliman AhmedSoliman merged commit 8f3cd00 into main Apr 30, 2024
5 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1483 branch April 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann