Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionProcessorManager as long-living service #1481

Merged
merged 3 commits into from
Apr 30, 2024
Merged

PartitionProcessorManager as long-living service #1481

merged 3 commits into from
Apr 30, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Apr 29, 2024 •
edited
Loading

This was referenced Apr 29, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

Test Results

 99 files  +4   99 suites  +4   8m 32s ⏱️ +45s
 84 tests +2   82 ✅ +2  2 💤 ±0  0 ❌ ±0 
216 runs  +4  210 ✅ +4  6 💤 ±0  0 ❌ ±0 

Results for commit b712970. ± Comparison against base commit 05eb4ba.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman mentioned this pull request Apr 29, 2024
Merged
@AhmedSoliman AhmedSoliman marked this pull request as ready for review April 29, 2024 17:27
tillrohrmann
tillrohrmann approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AhmedSoliman. LGTM. +1 for merging.

@AhmedSoliman AhmedSoliman mentioned this pull request Apr 30, 2024
Merged
@AhmedSoliman AhmedSoliman mentioned this pull request Apr 30, 2024
Merged
@AhmedSoliman
Introducing per-partition PartitionStore
65a20aa 
**IMPORTANT:** This breaks queries through datafusion until we workout how data fusion will shard queries across partitions.
@AhmedSoliman
Rename storage-rocksdb to partition-store
7bf3d22
@AhmedSoliman
PartitionProcessorManager as long-living service
25e45df
@AhmedSoliman AhmedSoliman merged commit 25e45df into main Apr 30, 2024
5 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1481 branch April 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann