-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rescript tool tweaks #7160
Rescript tool tweaks #7160
Conversation
@cknitt, did you have a chance to check the failing build here? |
Hmm, one thing is that the buildjet runners are still not working. The other is this
which occurs on all the other runners. I have not that seen before, and it does not seem related to any changes in this PR. Will look into it a bit more tomorrow. |
6005883
to
8e12704
Compare
Hello @cknitt, could you review this one please? |
Co-authored-by: Christoph Knittel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM! But maybe @zth who knows more about rescript-tools should have a look, too?
I'm not against that, but it did kinda happen in rescript-lang/rescript-vscode#1043 |
Ah ok, sorry! Good to go then, I will merge. |
Thanks a bunch @cknitt! |
No description provided.