Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional signature information to doc json #1043

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 19, 2024

Subset of #1041

@nojaf nojaf mentioned this pull request Oct 19, 2024
tools/src/tools.ml Outdated Show resolved Hide resolved
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and try it out as it's purely additive.

@nojaf
Copy link
Contributor Author

nojaf commented Oct 21, 2024

Thank you for the review, @zth!

This leaves the PR in a bit of a puzzled state. What is the next action, and who should take it? There is both a remark and an approval.

My goal is to have a new version of the tool on npm if possible. What does it take to reach that level? As a contributor, I'm left to speculate about what comes next.

@zth
Copy link
Collaborator

zth commented Oct 21, 2024

Thank you for the review, @zth!

This leaves the PR in a bit of a puzzled state. What is the next action, and who should take it? There is both a remark and an approval.

My goal is to have a new version of the tool on npm if possible. What does it take to reach that level? As a contributor, I'm left to speculate about what comes next.

Well, I left a comment that I'd like to at least have acknowledged before we can merge.

tools/src/tools.ml Outdated Show resolved Hide resolved
@zth
Copy link
Collaborator

zth commented Oct 22, 2024

Great stuff! Releasing tonight.

@zth zth merged commit 3b1014e into rescript-lang:master Oct 22, 2024
6 checks passed
@nojaf nojaf deleted the signature-info-json branch October 22, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants