Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore egui_plot auto-bounds state after dragging the time cursor in timeseries space views #4270

Merged
merged 18 commits into from
Dec 1, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 20, 2023

What

Ignore the commit history 😅

Export-1701442441839

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added blocked can't make progress right now ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 20, 2023
@abey79 abey79 mentioned this pull request Nov 27, 2023
34 tasks
Wumpf added a commit that referenced this pull request Nov 28, 2023
### What

* Fixes #4267

TODO for final release:
* [x] Update links, fix all `?speculative-link`
* [x] cherry pick #4349
* [x] cherry pick #4350
* [x] cherry pick #4351
* [x] cherry pick #4354
* [x] Write changelog (and review thereof)
  * Known limitation of Visible History worth mentioning:
     * [x] #4270
     * [x] #723
* [x] testing:
   * special care this time about:
* Blueprint error messages (use outdated stuff you have on your machine
to stretch it!)
* UI changes (selection panel, visual history things - in particular on
the plot)
* C++ cmake install (follow public instructions - if they don't help the
instructions are bad!)
   * [x] Windows
      * [x] Native
           * blueprint ok 0.10.0-rc.1 -> 0.11-rc.1
* found spurious wgpu related crash, seems to be fixed on latest wgpu.
Details on Slack
           * C++ visual studio project for unziped sdk works
* Cmake install works. With path with spaces after applying
#4351
      * [x] Browser
   * [x] Linux
      * [x] Native
      * [x] Browser
   * [x] Mac
       * [x] Native
         * [x] blueprint ok 0.10.1 -> 0.11
         * [x] UI changes ok
       * [x] Browser
   * [x] python package (any platform)
       * [x] tested on mac, seems ok except:
       * [x] ~~couldn't load example rrds~~ fixed 
   * [x] C++ cmake install (any platform)
        * tested on linux 
   * [x] Rust crate (any platform)
* [x] finish opencv/eigen example update

TODO just after release:
* [x] Update webpage with blog
* [x] Merge opencv/eigen example update
* [x] github release update
* [x] post on social

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4347) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4347)
- [Docs
preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: rerun-bot <[email protected]>
Co-authored-by: jprochazk <[email protected]>
Co-authored-by: Jeremy Leibs <[email protected]>
teh-cmc pushed a commit that referenced this pull request Nov 30, 2023
### What

* Fixes #4267

TODO for final release:
* [x] Update links, fix all `?speculative-link`
* [x] cherry pick #4349
* [x] cherry pick #4350
* [x] cherry pick #4351
* [x] cherry pick #4354
* [x] Write changelog (and review thereof)
  * Known limitation of Visible History worth mentioning:
     * [x] #4270
     * [x] #723
* [x] testing:
   * special care this time about:
* Blueprint error messages (use outdated stuff you have on your machine
to stretch it!)
* UI changes (selection panel, visual history things - in particular on
the plot)
* C++ cmake install (follow public instructions - if they don't help the
instructions are bad!)
   * [x] Windows
      * [x] Native
           * blueprint ok 0.10.0-rc.1 -> 0.11-rc.1
* found spurious wgpu related crash, seems to be fixed on latest wgpu.
Details on Slack
           * C++ visual studio project for unziped sdk works
* Cmake install works. With path with spaces after applying
#4351
      * [x] Browser
   * [x] Linux
      * [x] Native
      * [x] Browser
   * [x] Mac
       * [x] Native
         * [x] blueprint ok 0.10.1 -> 0.11
         * [x] UI changes ok
       * [x] Browser
   * [x] python package (any platform)
       * [x] tested on mac, seems ok except:
       * [x] ~~couldn't load example rrds~~ fixed 
   * [x] C++ cmake install (any platform)
        * tested on linux 
   * [x] Rust crate (any platform)
* [x] finish opencv/eigen example update

TODO just after release:
* [x] Update webpage with blog
* [x] Merge opencv/eigen example update
* [x] github release update
* [x] post on social

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4347) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4347)
- [Docs
preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: rerun-bot <[email protected]>
Co-authored-by: jprochazk <[email protected]>
Co-authored-by: Jeremy Leibs <[email protected]>
Base automatically changed from andreas/wgpu-0.18 to main December 1, 2023 08:58
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	crates/re_ui/examples/re_ui_example.rs
#	crates/re_viewer/src/app.rs
#	crates/re_viewer/src/native.rs
#	crates/re_viewer/src/ui/top_panel.rs
#	deny.toml
@abey79 abey79 added include in changelog and removed blocked can't make progress right now exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 1, 2023
@abey79 abey79 changed the title Restore egui_plot auto-bounds state after dragging the time cursor in timeseries space views Restore egui_plot auto-bounds state after dragging the time cursor in timeseries space views Dec 1, 2023
@abey79 abey79 marked this pull request as ready for review December 1, 2023 14:55
@abey79 abey79 merged commit e3dd6f3 into main Dec 1, 2023
44 of 46 checks passed
@abey79 abey79 deleted the antoine/fix-timeseries-auto-bounds branch December 1, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interacting with the time cursor in timeseries unexpectedly disengage the auto-bound behaviour
3 participants