Fix c++ spawn failure by handling empty string properly #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
🪳 bug
Wumpf
approved these changes
Nov 27, 2023
jleibs
force-pushed
the
jleibs/fix_cpp_spawn
branch
from
1e0afa4 to
91d08d9
Compare
Wumpf
pushed a commit
that referenced
this pull request
Nov 28, 2023
### What Empty is a more robust check than null since it also catches the empty string. I'm torn on whether to also check for null here -- my inclination is not to since I'd rather raise the unexpected null error since if someone is passing an StringView with a nullptr but non-zero length, they are doing something wrong. * closes #4348 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4349) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4349) - [Docs preview](https://rerun.io/preview/91d08d9950b844e4ac02c0214c7bfe3a54d3bee1/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/91d08d9950b844e4ac02c0214c7bfe3a54d3bee1/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Wumpf
added a commit
that referenced
this pull request
Nov 28, 2023
### What * Fixes #4267 TODO for final release: * [x] Update links, fix all `?speculative-link` * [x] cherry pick #4349 * [x] cherry pick #4350 * [x] cherry pick #4351 * [x] cherry pick #4354 * [x] Write changelog (and review thereof) * Known limitation of Visible History worth mentioning: * [x] #4270 * [x] #723 * [x] testing: * special care this time about: * Blueprint error messages (use outdated stuff you have on your machine to stretch it!) * UI changes (selection panel, visual history things - in particular on the plot) * C++ cmake install (follow public instructions - if they don't help the instructions are bad!) * [x] Windows * [x] Native * blueprint ok 0.10.0-rc.1 -> 0.11-rc.1 * found spurious wgpu related crash, seems to be fixed on latest wgpu. Details on Slack * C++ visual studio project for unziped sdk works * Cmake install works. With path with spaces after applying #4351 * [x] Browser * [x] Linux * [x] Native * [x] Browser * [x] Mac * [x] Native * [x] blueprint ok 0.10.1 -> 0.11 * [x] UI changes ok * [x] Browser * [x] python package (any platform) * [x] tested on mac, seems ok except: * [x] ~~couldn't load example rrds~~ fixed * [x] C++ cmake install (any platform) * tested on linux * [x] Rust crate (any platform) * [x] finish opencv/eigen example update TODO just after release: * [x] Update webpage with blog * [x] Merge opencv/eigen example update * [x] github release update * [x] post on social ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4347) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4347) - [Docs preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <[email protected]> Co-authored-by: rerun-bot <[email protected]> Co-authored-by: jprochazk <[email protected]> Co-authored-by: Jeremy Leibs <[email protected]>
teh-cmc
pushed a commit
that referenced
this pull request
Nov 30, 2023
### What Empty is a more robust check than null since it also catches the empty string. I'm torn on whether to also check for null here -- my inclination is not to since I'd rather raise the unexpected null error since if someone is passing an StringView with a nullptr but non-zero length, they are doing something wrong. * closes #4348 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4349) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4349) - [Docs preview](https://rerun.io/preview/91d08d9950b844e4ac02c0214c7bfe3a54d3bee1/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/91d08d9950b844e4ac02c0214c7bfe3a54d3bee1/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
teh-cmc
pushed a commit
that referenced
this pull request
Nov 30, 2023
### What * Fixes #4267 TODO for final release: * [x] Update links, fix all `?speculative-link` * [x] cherry pick #4349 * [x] cherry pick #4350 * [x] cherry pick #4351 * [x] cherry pick #4354 * [x] Write changelog (and review thereof) * Known limitation of Visible History worth mentioning: * [x] #4270 * [x] #723 * [x] testing: * special care this time about: * Blueprint error messages (use outdated stuff you have on your machine to stretch it!) * UI changes (selection panel, visual history things - in particular on the plot) * C++ cmake install (follow public instructions - if they don't help the instructions are bad!) * [x] Windows * [x] Native * blueprint ok 0.10.0-rc.1 -> 0.11-rc.1 * found spurious wgpu related crash, seems to be fixed on latest wgpu. Details on Slack * C++ visual studio project for unziped sdk works * Cmake install works. With path with spaces after applying #4351 * [x] Browser * [x] Linux * [x] Native * [x] Browser * [x] Mac * [x] Native * [x] blueprint ok 0.10.1 -> 0.11 * [x] UI changes ok * [x] Browser * [x] python package (any platform) * [x] tested on mac, seems ok except: * [x] ~~couldn't load example rrds~~ fixed * [x] C++ cmake install (any platform) * tested on linux * [x] Rust crate (any platform) * [x] finish opencv/eigen example update TODO just after release: * [x] Update webpage with blog * [x] Merge opencv/eigen example update * [x] github release update * [x] post on social ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4347) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4347) - [Docs preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <[email protected]> Co-authored-by: rerun-bot <[email protected]> Co-authored-by: jprochazk <[email protected]> Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Empty is a more robust check than null since it also catches the empty string.
I'm torn on whether to also check for null here -- my inclination is not to since I'd rather raise the unexpected null error since if someone is passing an StringView with a nullptr but non-zero length, they are doing something wrong.
Checklist