Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1044] Update date hashes on reset date range #1068

Merged
merged 3 commits into from
Mar 2, 2020
Merged

[#1044] Update date hashes on reset date range #1068

merged 3 commits into from
Mar 2, 2020

Conversation

ccyccyccy
Copy link
Contributor

Fixes #1044

Resetting the date range would occasionally not change the date hashes
in the url, causing a refresh of the page to load the outdated filter
date range. The bug occurs when until or since date is not specified on
generating the report.

Let's make sure that the date hashes gets updated all the time.

@anubh-v
Copy link
Contributor

anubh-v commented Feb 13, 2020

Is this ok for review?

@ccyccyccy
Copy link
Contributor Author

Is this ok for review?

Yes this is ready for review.

@ccyccyccy ccyccyccy requested a review from a team February 14, 2020 10:18
@jamessspanggg jamessspanggg requested a review from a team February 20, 2020 05:30
@fzdy1914
Copy link
Member

@ccyccyccy Can you update the branch, please. Meanwhile, can you tick the allow the maintainer to edit this branch when creating new PRs so we can update the branch for you.

@ccyccyccy
Copy link
Contributor Author

@ccyccyccy Can you update the branch, please. Meanwhile, can you tick the allow the maintainer to edit this branch when creating new PRs so we can update the branch for you.

Thanks. Will do in the future. Just updated the branch.

@fzdy1914 fzdy1914 merged commit 43c1898 into reposense:master Mar 2, 2020
Tejas2805 added a commit to Tejas2805/RepoSense that referenced this pull request Mar 6, 2020
@Tejas2805
Merge branch 'master' of https://github.com/reposense/RepoSense
05fc559 
* 'master' of https://github.com/reposense/RepoSense:
  [reposense#1047] v_summary: simplify toDisplay user logic (reposense#1051)
  [reposense#658] Modify checkstyle configuration (reposense#1094)
  Add commit message length configuration border (reposense#1048)
  [reposense#1061] build.gradle: remove unused dependency (reposense#1095)
  [reposense#1044] Update date hashes on reset date range (reposense#1068)
@FH-30 FH-30 mentioned this pull request Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinyao-lee jinyao-lee jinyao-lee approved these changes

@anubh-v anubh-v anubh-v approved these changes

@fzdy1914 fzdy1914 fzdy1914 approved these changes

@jamessspanggg jamessspanggg jamessspanggg approved these changes

@eugenepeh eugenepeh eugenepeh approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reset date range does not update the since and until date hashes
6 participants
@ccyccyccy @anubh-v @fzdy1914 @eugenepeh @jamessspanggg @jinyao-lee