Reset date range does not update the since and until date hashes

[jamessspanggg]

To reproduce: modify the link since/until date url hashes. Reload the page. Click the reset date range button. Reload again to see that the dates are not updated. link

[Tejas2805]

It seems to be working fine on mine.

[jamessspanggg]

@Tejas2805 can you try to following the steps to see if the same bug can be reproduced?

To reproduce: modify the link since/until date url hashes. Reload the page. Click the reset date range button. Reload again to see that the dates are not updated. link

[ccyccyccy]

I believe this bug only happens you do not specify the since and until date in the command line to generate the report, which as a result sets the hasModifiedSinceDate and hasModifiedUntilDate to false on initial loading of the page.

I can do a PR to remove the check below, but I believe we can remove the hasModifiedSinceDate and hasModifiedUntilDate all together? I'm not too sure if they serve any purpose? @jamessspanggg

[0blivious]

The code here did serve a purpose. It stores the date range and help restore the page when refresh. Pls dont remove it.

[ccyccyccy]

Oops I mean removing the if() statements.
So instead of

if (this.hasModifiedSinceDate) {
        addHash('since', this.filterSinceDate);
}

if (this.hasModifiedUntilDate) {
        addHash('until', this.filterUntilDate);
}

We can change it to

addHash('since', this.filterSinceDate);
addHash('until', this.filterUntilDate);

[ccyccyccy]

I believe that the hasModifiedSinceDate indicates whether a value has been specified in the command line argument to generate the report, as written in the line
hasModifiedSinceDate: window.app.isSinceDateProvided
in v_summary.js, but is currently interpreted as whether a filter is set by the user on the dashboard.

[0blivious]

I feel we should not add the hash if there is no need to do so. Maybe you should change the reset date function to rectify the behavior.

[ccyccyccy]

I feel we should not add the hash if there is no need to do so. Maybe you should change the reset date function to rectify the behavior.

Thanks for the suggestion. I implemented a simple fix (#1044) that would solve the issue but I feel that it's not very maintainable.

I believe that the hasModifiedSinceDate indicates whether a value has been specified in the command line argument to generate the report, as written in the line
hasModifiedSinceDate: window.app.isSinceDateProvided
in v_summary.js, but is currently interpreted as whether a filter is set by the user on the dashboard.

@jamessspanggg Can you help verify this? I'm not too certain if this is the case. The code was authored by you in #757

[jamessspanggg]

I believe that the hasModifiedSinceDate indicates whether a value has been specified in the command line argument to generate the report,

@0blivious is correct. The purpose of hasModifiedSinceDate and hasModifiedUntilDate was to indicate whether the dates are specified in the CLI. This is because prof wants a way to always display the latest since/until date, if he did not specify the since/until date in the CLI. With this, prof does not need to always send a new link whenever he updates the analysis, but students can use the same link to get the most updated since/until date.