Add assert for eTags and uploadLinks

[callingmedic911]

I can’t think if this would even be possible, but I am adding this assert so it will surface if it somehow happens

Related PRO-715.

[changeset-bot]

⚠️ No Changeset found

Latest commit: b439f65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[replay-io]

Status	In Progress ↗︎
Commit	8198832
Results	❌ 2 Failed clicks a disappearing button should fail on this test ✅ 38 Passed adds items adds new items using a custom command adds todos following the fixture adds todos following the fixture adds todos following the fixture calls inform complete all checkbox should update state when items are completed / cleared gets a number only gets a number only gets a number should allow me to add todo items should allow me to clear the complete state of all items should allow me to display active items should allow me to display all items should allow me to display completed items should allow me to edit an item should allow me to mark all items as completed should allow me to mark items as complete should allow me to un-mark items as complete should append new items to the bottom of the list should be hidden when there are no items that are completed should cancel edits on escape should clear text input field when an item is added should display the correct text should hide other controls when editing should highlight the currently applied filter should intercept postman should invoke some commands that have exceptional option handling should log should persist its data should remove completed items when clicked should remove the item if an empty text string was entered should respect the back button should save edits on blur should show #main and #footer when items added should trim entered text should trim text input yields a number

[bvaughn]

Should we add a similar assert to replayio too just to be safe?

[callingmedic911]

repalyio checks if each response has etag, that should be good enough I think.

replay-cli/packages/shared/src/recording/upload/uploadRecording.ts

Line 274 in 33656ea

assert(etag, "Etag has to be returned in the response headers");

[bvaughn]

Oh cool