Add assert for eTags and uploadLinks (#588)

replayio · Jul 2, 2024 · 4f1dd73 · 4f1dd73
1 parent 543dfc9
commit 4f1dd73
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/replay/src/main.ts b/packages/replay/src/main.ts
@@ -5,6 +5,7 @@ import { getPackument } from "query-registry";
 import { compare } from "semver";
 import dbg from "./debug";
 import { getCurrentVersion, getHttpAgent } from "./utils";
+import assert from "node:assert/strict";
 
 // requiring v4 explicitly because it's the last version with commonjs support.
 // Should be upgraded to the latest when converting this code to es modules.
@@ -241,6 +242,8 @@ async function multipartUploadRecording(
     agentOptions
   );
 
+  assert(eTags.length === partLinks.length, "Mismatched eTags and partLinks");
+
   await client.connectionEndRecordingMultipartUpload(recording.id, uploadId, eTags);
   return recordingId;
 }

diff --git a/packages/test-utils/src/legacy-cli/main.ts b/packages/test-utils/src/legacy-cli/main.ts
@@ -2,6 +2,7 @@ import { retryWithExponentialBackoff } from "@replay-cli/shared/async/retryOnFai
 import fs from "fs";
 import dbg from "./debug";
 import { getHttpAgent } from "./utils";
+import assert from "node:assert/strict";
 
 // requiring v4 explicitly because it's the last version with commonjs support.
 // Should be upgraded to the latest when converting this code to es modules.
@@ -226,6 +227,8 @@ async function multipartUploadRecording(
     agentOptions
   );
 
+  assert(eTags.length === partLinks.length, "Mismatched eTags and partLinks");
+
   await client.connectionEndRecordingMultipartUpload(recording.id, uploadId, eTags);
   return recordingId;
 }