-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "replayio open" command to launch browser in non-recording mode #526
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"replayio": patch | ||
--- | ||
|
||
Add "open" command to open Replay browser in non-recording mode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { killBrowserIfRunning } from "../utils/browser/killBrowserIfRunning"; | ||
import { launchBrowser } from "../utils/browser/launchBrowser"; | ||
import { registerCommand } from "../utils/commander/registerCommand"; | ||
import { exitProcess } from "../utils/exitProcess"; | ||
|
||
registerCommand("open", { checkForRuntimeUpdate: true, requireAuthentication: true }) | ||
.argument("[url]", `URL to open (default: "about:blank")`) | ||
.description("Open the replay browser with recording disabled") | ||
.action(open) | ||
.allowUnknownOption(); | ||
|
||
async function open(url: string = "about:blank") { | ||
await killBrowserIfRunning(); | ||
|
||
await launchBrowser(url, { record: false }); | ||
|
||
await exitProcess(0); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
packages/replayio/src/utils/browser/killBrowserIfRunning.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import { confirm } from "../confirm"; | ||
import { exitProcess } from "../exitProcess"; | ||
import { killProcess } from "../killProcess"; | ||
import { getRunningProcess } from "./getRunningProcess"; | ||
|
||
export async function killBrowserIfRunning() { | ||
const process = await getRunningProcess(); | ||
if (process) { | ||
const confirmed = await confirm( | ||
"The replay browser is already running. You'll need to close it before running this command.\n\nWould you like to close it now?", | ||
true | ||
); | ||
if (confirmed) { | ||
const killResult = await killProcess(process.pid); | ||
if (!killResult) { | ||
console.log("Something went wrong trying to close the replay browser. Please try again."); | ||
|
||
await exitProcess(1); | ||
} | ||
} else { | ||
await exitProcess(0); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL, what is this? test plugins dont set this at all (IIRC)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sideways: do u know what
RECORD_REPLAY_DRIVER
is for? test plugins use it but we don't use it hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL too. Jason mentioned it in Discord. All I know about it is that if it's set, it tells the runtime not to record anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Not the right person to answer that 😆