-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "replayio open" command to launch browser in non-recording mode #526
Conversation
🦋 Changeset detectedLatest commit: f7b447f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -28,9 +29,10 @@ export async function launchBrowser( | |||
]; | |||
const processOptions = { | |||
env: { | |||
RECORD_ALL_CONTENT: "1", | |||
RECORD_ALL_CONTENT: record ? "1" : undefined, | |||
RECORD_REPLAY_DONT_RECORD: record ? undefined : "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL, what is this? test plugins dont set this at all (IIRC)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sideways: do u know what RECORD_REPLAY_DRIVER
is for? test plugins use it but we don't use it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL too. Jason mentioned it in Discord. All I know about it is that if it's set, it tells the runtime not to record anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sideways: do u know what
RECORD_REPLAY_DRIVER
is for? test plugins use it but we don't use it here
No. Not the right person to answer that 😆
This has been requested so that people can do things like authentication (without Replay recording) before starting recording.