Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve description of two config options #27744

Closed
wants to merge 1 commit into from

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Improve description for two config options:
    • concurrentRequestLimit
    • maxRequestsPerSecond

Context

Follow up after PR:

Use the code styling for values like 0.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Mar 6, 2024

Let's leave for now in case we need to revert the previous commit

@HonkingGoose
Copy link
Collaborator Author

Let's leave for now in case we need to revert the previous commit

You reverted the previous commit with this PR:

The current description is fine, so we don't need my PR anymore.

@HonkingGoose HonkingGoose deleted the patch-2 branch March 13, 2024 10:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants