-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Limit HTTP concurrency and frequency by default #27621
feat: Limit HTTP concurrency and frequency by default #27621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these instead be in a default hostRules value?
I think it doesn't make too much sense, since we still have to hard-code this default value if there is no host rules found. |
HostRules are mergeable so it should always be found? Plus has more visibility in config docs |
|
🎉 This PR is included in version 37.228.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi 👋 I believe this caused our self hosted GitHub Action running time to increase from 10m to 2h, is there a way to disable it for all hosts? See #27759 |
Hi @erezrokah, could you try this host rule: "hostRules": [
{
"concurrentRequestLimit": 0,
"maxRequestsPerSecond": 0
}
] It seems to work for my local setup, hopefully it will help you. |
@rarkins Should we somehow make unlimited default for actions? And one more unrelated question: it's recommended to persist repository cache, but what about package cache? If it doesn't, would you recommend it? |
Which host/type is needing the increased rate and/or concurrency? I'm confused where/how actions comes into it |
Actually let's switch the discussion to #27759. We can revert this if necessary |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: