Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve commit message functionality #13328

Merged
merged 34 commits into from
May 2, 2022
Merged

refactor: improve commit message functionality #13328

merged 34 commits into from
May 2, 2022

Conversation

pret-a-porter
Copy link
Contributor

Changes:

  1. Implemented abstract class CommitMessage
  2. Implemented class CustomCommitMessage
  3. Implemented class SemanticCommitMessage
  4. Implemented factory CommitMessageFactory for creating instance of SemanticCommitMessage or CustomCommitMessage by provided shared renovate config

Context:

Extracted as part of PR #13197

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@pret-a-porter pret-a-porter mentioned this pull request Jan 2, 2022
Merged
6 tasks
@pret-a-porter pret-a-porter force-pushed the refactor/commit-message branch from ce2e3e2 to 91bbca5 Compare January 2, 2022 21:21
@rarkins
Copy link
Collaborator

rarkins commented Jan 3, 2022

For future reference, refactor PRs should ideally not change or remove tests (adding tests is OK). This PR as it is demands that the reviewer do a lot of manual testing, which increases the chance that it sits unreviewed.

@HonkingGoose HonkingGoose mentioned this pull request Jan 3, 2022
Merged
6 tasks
@pret-a-porter pret-a-porter requested a review from viceice January 9, 2022 20:21
viceice
viceice reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@rarkins rarkins marked this pull request as draft March 25, 2022 10:15
@rarkins
Copy link
Collaborator

rarkins commented Mar 25, 2022

Needs lint fix

@pret-a-porter pret-a-porter marked this pull request as ready for review March 25, 2022 20:37
@pret-a-porter
Copy link
Contributor Author

Fixed, ready to review again

@pret-a-porter pret-a-porter requested a review from viceice March 25, 2022 20:37
viceice
viceice reviewed Mar 26, 2022
View reviewed changes
lib/types/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/model/commit-message.ts Outdated Show resolved Hide resolved
lib/workers/repository/model/commit-message.ts Outdated Show resolved Hide resolved
@pret-a-porter pret-a-porter requested a review from viceice April 6, 2022 19:54
@pret-a-porter pret-a-porter requested a review from viceice April 10, 2022 15:10
viceice
viceice reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to send review. 🙈

lib/workers/repository/model/semantic-commit-message.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/model/semantic-commit-message.ts Outdated Show resolved Hide resolved
@pret-a-porter pret-a-porter requested a review from viceice April 16, 2022 18:02
viceice
viceice reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/workers/repository/model/commit-message.ts Outdated Show resolved Hide resolved
lib/workers/repository/model/custom-commit-message.spec.ts Outdated Show resolved Hide resolved
@viceice viceice mentioned this pull request Apr 25, 2022
Merged
6 tasks
@pret-a-porter pret-a-porter requested a review from viceice April 30, 2022 20:00
@pret-a-porter pret-a-porter requested a review from viceice May 1, 2022 08:52
@pret-a-porter pret-a-porter requested a review from viceice May 1, 2022 11:23
@viceice viceice enabled auto-merge (squash) May 2, 2022 01:32
@viceice viceice merged commit ed73d38 into renovatebot:main May 2, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.36.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pret-a-porter @rarkins @renovate-release @JamieMagee @viceice