-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: commit message #13197
fix: commit message #13197
Conversation
I feel concerned when there's so many changes to both implementation and tests at the same time - it's much easier for us to miss a regression test. @pret-a-porter can you split this, e.g. to change the tests part first with minimal changes to the implementation? |
Yeah, I can. It can be two next PR's:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocked by #13328
🎉 This PR is included in version 32.84.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Revert "fix: commit message (renovatebot#13197)" This reverts commit ed639b4.
Changes:
Context:
Fixes #12062
Documentation
How I've tested my work
I have verified these changes via: