Add option to settle payments in SyncSimulatedPaymentSession

[renepickhardt]

As realized through discussions with @sebulino in #15 the current lib does only decide if a payment can be delivered or not. In many cases it would be preferable that the liquidity is actually being moved in the OracleChannel and our belief about the uncertainty is updated in both arcs of the UncertaintyChannel where we would also have to set the inflight back to 0.

[sebulino]

This is my understanding of what is happening when pickhardt_pay is called on SyncSimulatedPaymentSession:

• pickhardt_pay is called on the SyncSimulatedPaymentSession
• a set of payments is created with fee, prob, path and amount
• payments are then passed to _attempt_payments in same Class
• _attempt_payments checks/calls send_onion on OracleLightningNetwork.
• send_onion in OracleLightningNetwork
  • sets keys to
    • either bool success to True and Erring Channel as None
    • or bool success to False and Erring Channel with the respective failing channel
    • (success of the probe is defined by can_foward in OracleChannel Class)
  • calls update_knowledge on UncertaintyChannel which sets new liquidity need, by increasing either minimum or maximum liquidity (subject to condition)

So far no update on OracleChannels in OracleLightningNetwork. This is what would make sense to be added.

[renepickhardt]

This is a very accurate summary of what is happening! Note that _attempt_payments is having this line:

pickhardtpayments/pickhardtpayments/SyncSimulatedPaymentSession.py

Line 250 in 8e44490

self._uncertainty_network.allocate_amount_on_path(

This is where we update our belief on the uncertainty network. IF you were to also update the Oracle here all future statistics would be skewed.

Therefor I guess it would be best from the point of view of the simulation to update the OracleChannels after all rounds have been completed. There may be two paths to success:

1. after the payment loop is completed go through all channels that have inflight and move it to the other side while removing it
2. if introduce loglevels and make prints in SyncSimulatedPayment Session optional #17 has landed and all the payment paths and statistics of a payment session are in a single data structure one could just go throught that (though it would have to include staistics of all rounds - right now we have stats just for a single round)

It's quite remarkable how involved such a little change would be and how much refactorig would probably be necessary. From the point of view that a siulation may wish to do concurrent tests it is probably better and cleaner to persue the 2nd option. That being said if you have better / other ideas I will be open