Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payments dict / attempt class #20

Open
renepickhardt opened this issue May 17, 2022 · 0 comments
Open

Payments dict / attempt class #20

renepickhardt opened this issue May 17, 2022 · 0 comments

Comments

@renepickhardt
Copy link
Owner

@sebulino rightfully pointed out in out of band communication that a dict for payments that is indexed by an incremental integer is just a list. Yet I introduced such a dict...

pickhardtpayments/pickhardtpayments/SyncSimulatedPaymentSession.py

Line 224 in 8e44490

payments[i] = {

Also within the payment loop we may wish to collect all attempts from all rounds so that we later can settle the attempts that can be delivered (as worked on in #18) this is also much easier if the attempts were a list. (attempts may wish to store in which round they were competed though)

Related: I think the payments datastructure should be a list of attempts and we may wish to create a small attempt class (I think that would generalize to other usecase of the package)
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue May 17, 2022
@sebulino
shell for a Payment Class for issue renepickhardt#20
c03fe39
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue May 17, 2022
@sebulino
shell for as Attempt Class for issue renepickhardt#20
7170150
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue May 29, 2022
@sebulino
initializes fee and probability w/ none (instead of -1) renepickhardt#20
5903cd2
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue May 30, 2022
@sebulino
shell for a Payment Class for issue renepickhardt#20
8dd0d3f
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue May 30, 2022
@sebulino
shell for as Attempt Class for issue renepickhardt#20
2db9a08
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue May 30, 2022
@sebulino
initializes fee and probability w/ none (instead of -1) renepickhardt#20
9da333d
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 1, 2022
@sebulino
shell for a Payment Class for issue renepickhardt#20
080eb28
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 1, 2022
@sebulino
shell for as Attempt Class for issue renepickhardt#20
7883011
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 1, 2022
@sebulino
initializes fee and probability w/ none (instead of -1) renepickhardt#20
fd539ec
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 3, 2022
@sebulino
shell for a Payment Class for issue renepickhardt#20
a879720
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 3, 2022
@sebulino
shell for as Attempt Class for issue renepickhardt#20
989c624
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 3, 2022
@sebulino
initializes fee and probability w/ none (instead of -1) renepickhardt#20
903d45b
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 3, 2022
@sebulino
shell for a Payment Class for issue renepickhardt#20
ca5ec75
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 22, 2022
@sebulino
shell for a Payment Class for issue renepickhardt#20
f14fe55
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 22, 2022
@sebulino
shell for as Attempt Class for issue renepickhardt#20
b198e40
sebulino added a commit to sebulino/pickhardtpayments that referenced this issue Jun 22, 2022
@sebulino
initializes fee and probability w/ none (instead of -1) renepickhardt#20
4f78919
renepickhardt added a commit that referenced this issue Jun 22, 2022
@sebulino @renepickhardt @nassersaazi
Introduction of AttemptClass and PaymentClass (Issue #20) (#24)
cd46871 
* add .gitignore

* introduce register payment method on OracleLightningNetwork.py

* adding settlement_payment in OracleLightningNetwork

first stub of a method as described in  #16
Still needs to be tested

* rewriting setter for `actual_liquidity` using properties (python way)

* adjust channels in both directions when payment is made

* Settlement of onions with partial payments only after all onions were routed successfully

* deletion of unused import

* shell for a Payment Class

* Revert "shell for a Payment Class"

This reverts commit 8dffa28.

* shell for a Payment Class for issue #20

* shell for as Attempt Class for issue #20

* Indroduction of Payment and Attempt class, refactoring.

* Introduction of PaymentClass and AttemptClass, refactoring.

* error fixing, semantic changes and refinement of Payment ant Attempt class

* adding types in methods for Attempt and Payment Class and amending relative paths on imports

* initializes fee and probability w/ none (instead of -1) #20

* adjustment of relative paths for modules in import

* extending .gitignore

* correcting tipo for gitignore

* init for documentation

* configuration updated

* correction in filter function for Attempt.Status #24

* changing imports back to initial call

* fixing issues from partial review
#24 (review)

* deleting docs folder and moving _estimate_payment_statistics into attempt class

* deleting docs folder and moving _estimate_payment_statistics into attempt class

* removed doc folder

* adding CHANGELOG

* Cleaning up after Attempt and Payment PR review

* changed filter function in payment to generator

* added setter to OracleChannel and fixed imports in init.py

* Fix typos in documentation

* rewriting setter for `actual_liquidity` using properties (python way)

* Indroduction of Payment and Attempt class, refactoring.

* Introduction of PaymentClass and AttemptClass, refactoring.

* adjustment of relative paths for modules in import

* changing imports back to initial call

* another rebasing hassle ;)

Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Rene Pickhardt <[email protected]>
Co-authored-by: nassersaazi <[email protected]>
adamritter added a commit to adamritter/pickhardtpayments that referenced this issue Aug 5, 2022
@adamritter
Revert "Introduction of AttemptClass and PaymentClass (Issue renepick…
4b2a1b1 
…hardt#20) (renepickhardt#24)"

This reverts commit cd46871.
adamritter added a commit to adamritter/pickhardtpayments that referenced this issue Aug 5, 2022
@adamritter
Revert "Introduction of AttemptClass and PaymentClass (Issue renepick…
e149e6b 
…hardt#20) (renepickhardt#24)"

This reverts commit cd46871.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@renepickhardt