Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export NavigationType enum as value. #8529

Merged
merged 2 commits into from
Feb 27, 2022
Merged

feat: export NavigationType enum as value. #8529

merged 2 commits into from
Feb 27, 2022

Conversation

latin-1
Copy link
Contributor

@latin-1 latin-1 commented Dec 25, 2021

addresses #8475

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 25, 2021

Hi @latin-1,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 25, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

Thanks for the PR @latin-1 ! Would you mind pointing this to the dev branch since it changes the code? Then I think this is good to be merged 👍

@latin-1 latin-1 changed the base branch from main to dev February 26, 2022 06:50
@latin-1
Copy link
Contributor Author

latin-1 commented Feb 26, 2022

I've changed the target branch to dev and rebased it.

@timdorr
Copy link
Member

timdorr commented Feb 27, 2022

Thanks!

@timdorr timdorr merged commit 09aa24f into remix-run:dev Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants