Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail gracefully when security settings prevent access to sessionStorage #120

Merged

Conversation

masonicboom
Copy link
Contributor

This can happen (at least) in iOS 9 Mobile Safari, when "Block Cookies" is set to "Always Block" (angular-translate/angular-translate#629 suggests this has been true since iOS 7.1.2).

@taion
Copy link
Contributor

taion commented Oct 29, 2015

This is the same as #99. I think we just want to handle everything in #104.

@mjackson
Copy link
Member

This is a different error, @taion. #104 is about handling errors when the quota is actually exceeded. This PR is about handling errors when cookies are disabled in a specific environment.

@taion
Copy link
Contributor

taion commented Oct 29, 2015

It's not the same as #104, but it's a more targeted version of the same check as #99, geared toward the same thing. I guess we'd merge these separately and resolve the conflicts later?

@mjackson
Copy link
Member

mjackson commented Nov 2, 2015

Thanks, @masonicboom!

@taion Yes, we'll resolve and merge #104 separately.

mjackson added a commit that referenced this pull request Nov 2, 2015
…cted

Fail gracefully when security settings prevent access to sessionStorage
@mjackson mjackson merged commit 12f7f2b into remix-run:master Nov 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants