-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling DOMStateStorage failures #123
Comments
FWIW (probably not much), the angular project uses |
Whoa, great catch @kentcdodds. Thanks for pointing that out. Can you help me understand how people use that? Is it mainly for dev? |
Pretty much soley for dev |
Basically, for perf, angular has the ability to disable dev related info. Useful for production deploys. But when you need to debug a production app, having that debug info is helpful. But you need a full page refresh to turn it on. So to store state across the page reload, angular uses window.name. |
Gonna close this until one of us finds time to work on it. |
Currently, we just warn when calls to
DOMStateStorage
'ssaveState
andreadState
fail. However, warnings don't really seem right here since the app will be broken.One idea I had is that we could possibly fallback to using
window.name
for session storage instead ofwindow.sessionStorage
. The main limitations here would be:window.name
. This is highly unlikely sincewindow.name
is a really obscure API, but we'll definitely want to put a caveat in the docs so people at least know about it.Thoughts?
Edit: This is a follow-up to #120
The text was updated successfully, but these errors were encountered: