edgeTransport 2.0 release #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
jmuessel
approved these changes
Jul 18, 2024
()
Outdated
| jPlease enter the commit message for your changes. Lines starting | ||
| # with '#' will be ignored, and an empty message aborts the commit. | ||
| # | ||
| # On branch develop |
There was a problem hiding this comment.
hmm i dont know.. maybe we can just delete it?
| @@ -27,10 +27,10 @@ cfg$regionmapping <- "config/regionmappingH12.csv" | |||
| ### Additional (optional) region mapping, so that those validation data can be loaded that contain the corresponding additional regions. | |||
| cfg$extramappings_historic <- "" | |||
| #### Current input data revision (<mainrevision>.<subrevision>) #### | |||
| cfg$inputRevision <- "6.79" | |||
| cfg$inputRevision <- "6.83edgeTransportReloaded" | |||
There was a problem hiding this comment.
this input data sound abit like test-data. We do not have input data with a "better" version number, right?
core/sets.gms
Outdated
| @@ -76,7 +76,7 @@ gdp_SSP2EU_NAV_lce "NAVIGATE demand scenarios: Low consumption energy (act + tec | |||
| gdp_SSP2EU_NAV_all "NAVIGATE demand scenarios: All measures (ele + act + tec)" | |||
| gdp_SSP2EU_CAMP_weak "CAMPAIGNers scenario with low ambition lifestyle change" | |||
| gdp_SSP2EU_CAMP_strong "CAMPAIGNers scenario with high ambition lifestyle change" | |||
| gdp_SSP2EU_demRedWeak | |||
| gdp_SSP2EU_demRedStrong | |||
There was a problem hiding this comment.
please add an explanation of this scenario
eval
Outdated
eval.parent
Outdated
| @@ -147,7 +147,7 @@ Parameter | |||
| p29_trpdemand "transport demand" | |||
| / | |||
| $ondelim | |||
| $include "./modules/29_CES_parameters/calibrate/input/pm_trp_demand.cs4r" | |||
| $include "./modules/29_CES_parameters/calibrate/input/f29_trpdemand.cs4r" | |||
There was a problem hiding this comment.
you also renamed the file in fullREMIND, right?
renv.lock
Outdated
There was a problem hiding this comment.
also not part of our Git repo
jmuessel
approved these changes
Jul 18, 2024
|
Sorry to say, but after this merge REMIND is dysfunctional, see Please run |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Adjusting REMIND to function with the new edgeTransport 2.0 version:
Changes include:
-Change transport scenario names in sets and scenario config
-Remove files/scenarios no longer needed
-Include new transport input data files
-Adjust function calls
-Change package dependencies
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information (optional):
This PR will be merged with several other PRs related to the switch to edgeTransport 2.0: