-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename EDGET Vars #331
rename EDGET Vars #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Might you have a look at pik-piam/edgeTransport#244 and remove all piam_variables in the AR6 template that are not provided by EDGE-T anymore (or never were)?
As requested in this issue: pik-piam/edgeTransport#244
…nto renameTransportVaribles
@orichters I deleted some variables according to the issue you mentioned and integrated your changes from today in the navigate template. Do you think we are ready to merge now? Of course after the edgeT-merge, which will introduce the new variable names. |
If |
…nto renameTransportVaribles
…nto renameTransportVaribles
Purpose of this PR
During the edgeT refactoring we changed variable names and, accordingly, did this as well in piamInterfaces and remind2 (see PR).
I will only merge this PR AFTER the refactoring is merged and want to prepare this PR now to follow up quickly.
In addition, I deleted missing variables from the AR6 mapping, as requested in this issue.
Checklist:
renamed_piam_variables.csv
to guarantee backwards compatibility.It is recommended to have a look at the tutorial before submission.
This PR will be merged with several other PRs related to the switch to edgeTransport 2.0: