Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename EDGET Vars #331

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Conversation

jmuessel
Copy link
Contributor

@jmuessel jmuessel commented Jul 10, 2024

Purpose of this PR

During the edgeT refactoring we changed variable names and, accordingly, did this as well in piamInterfaces and remind2 (see PR).
I will only merge this PR AFTER the refactoring is merged and want to prepare this PR now to follow up quickly.

In addition, I deleted missing variables from the AR6 mapping, as requested in this issue.

  • Emi|CO2|Transport|Freight|Short-Medium Distance|Demand (Mt CO2/yr)
  • Emi|CO2|Transport|Pass|Short-Medium Distance|Demand (Mt CO2/yr)
  • UE|per capita|Transport|Pass (GJ/cap/yr)

Checklist:

  • I did not use Excel to open csv files or checked that no side-effects occur (changed values, many new quotation marks, …)
  • I added any renamed piam_variable to renamed_piam_variables.csv to guarantee backwards compatibility.

It is recommended to have a look at the tutorial before submission.

This PR will be merged with several other PRs related to the switch to edgeTransport 2.0:

@jmuessel jmuessel requested a review from orichters July 10, 2024 19:58
Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Might you have a look at pik-piam/edgeTransport#244 and remove all piam_variables in the AR6 template that are not provided by EDGE-T anymore (or never were)?

@jmuessel
Copy link
Contributor Author

@orichters I deleted some variables according to the issue you mentioned and integrated your changes from today in the navigate template. Do you think we are ready to merge now? Of course after the edgeT-merge, which will introduce the new variable names.

@orichters
Copy link
Contributor

If make test works, we are good to go, I think.

@jmuessel jmuessel merged commit 8bbc51d into pik-piam:master Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants