Upgrade Kotlin to v1.6 across the board

[gnarea]

I've been putting this off due to the nightmares caused by the Kotlin 1.5 upgrade, but I'd like to think it'd be different this time.

The most important lesson I learnt last time is to do the upgrade in the following phases, to make debugging manageable:

1. Upgrade all the build- and run-time dependencies in the Awala libraries* (core, PoWeb, etc), but don't upgrade Kotlin yet.
2. Upgrade all the build/runtime/testing/etc dependencies in the apps* (Gateway, Courier and Ping), but don't upgrade Kotlin yet.
3. Test the apps and fix any upgrade issues.
4. Upgrade Kotlin across all libraries and merge into the main branch.
5. Update the apps to use Kotlin 1.6 along with the latest versions of the Awala libraries.

* I'd rather defer the upgrade to ktor v2 if we can, because that's a mini project in its own right.

Thoughts, @sdsantos?

[sdsantos]

@gnarea sounds like a good plan. I'm not sure how far being we are on the other dependencies to assess how risky it is to skip steps 1 and 2. Nevertheless, this needs one of those huge todo lists with all the steps for all the repos.

[gnarea]

Great! Based on past experience, my hunch is that anything that isn't ktor/kotlin will be easy to upgrade, but I could be proven wrong!

[sdsantos]

So, here's a big to-do list:

1. Upgrade all the build- and run-time dependencies in the Awala libraries* (core, PoWeb, etc), but don't upgrade Kotlin yet.

• awala-jvm (no update needed)
• awala-testing-jvm (fix(deps): Update Awala JVM minimum supported version to 1.65.0 awala-testing-jvm#86)
• awala-poweb-jvm (fix(deps): Update awala-jvm to v1.65.0 awala-poweb-jvm#222)
• awala-cogrpc-jvm (fix(deps): Update gRPC to 1.46.0 and Awala to 1.65.0 awala-cogrpc-jvm#244)
• awala-cogrpc-okhttp-jvm (fix(deps): Update cogrpc to 1.1.21 and grpc-okhttp to 1.46.0 awala-cogrpc-okhttp-jvm#100)
• awala-keystore-file-jvm (chore(deps): Update ktlint and awala testing awala-keystore-file-jvm#50)
• awala-endpoint-android (fix(deps): Update awala-keystore-file to 1.6.1 and poweb to 1.5.26 awala-endpoint-android#236)

2. Upgrade all the build/runtime/testing/etc dependencies in the apps* (Gateway, Courier and Ping), but don't upgrade Kotlin yet.

• awala-courier-android (fix(deps): Update dependencies (Kotlin 1.6) relaynet-courier-android#521)
• awala-gateway-android (fix(deps): Update dependencies (Kotlin 1.6) relaynet-gateway-android#623)
• awala-ping-android (fix(deps): Update dependencies (Kotlin 1.6) awala-ping-android#249)

3. Test the apps and fix any upgrade issues.

• awala-courier-android
• awala-gateway-android
• awala-ping-android

4. Upgrade Kotlin across all libraries and merge into the main branch.

• awala-jvm
• awala-testing-jvm
• awala-poweb-jvm
• awala-cogrpc-jvm
• awala-cogrpc-okhttp-jvm
• awala-keystore-file-jvm
• awala-endpoint-android

5. Update the apps to use Kotlin 1.6 along with the latest versions of the Awala libraries. (defer the upgrade to ktor v2 if possible)

• awala-courier-android
• awala-gateway-android
• awala-ping-android

6. Extra issues (optional)

• Lint issue: Invalid package reference in io.grpc:grpc-core awala-cogrpc-jvm#250

[gnarea]

LGTM 👌🏾

FYI, there's also the DoH library, but an external contributor is working on it (relaycorp/doh-jvm#128). It does mean, however, that we can't upgrade the DoH lib in the apps for the time being.

[Filmaluco]

Related to point 2. awala-ping-android task the PR can be found here:
relaycorp/awala-ping-android#249

[Filmaluco]

Related to point 2. awala-gateway-android task the PR can be found here:
relaycorp/relaynet-gateway-android#623

[Filmaluco]

Related to point 2. relaynet-courier-android task the PR can be found here:
relaycorp/relaynet-courier-android#521

[Filmaluco]

Related to point 3, I tested both the Gateway and the Ping app... and issues should be fixed on the branches aboves

[gnarea]

Related to point 3, I tested both the Gateway and the Ping app

Do you mean both apps had the latest code from those branches?

[Filmaluco]

@gnarea yes :)
update: (08/06/2022) I have now also tested Courier

[Filmaluco]

Related to task 4: ✅

Except awala-poweb-jvm is missing on PRs approvals for:

• fix(deps): kotlin(1.6.21) and coroutines(1.6.2) awala-poweb-jvm#228
• fix(deps): update awala-jvm min version awala-poweb-jvm#229

[Filmaluco]

@gnarea awala-gateway-android still is using 1.5.21, (point 5.) is the last one missing, I will take care of it but worth mentioning.

[gnarea]

Good catch @Filmaluco! That TODO list is out-of-date but I thought all the apps were updated. I'll reopen this.

[Filmaluco]

@gnarea I believe this can now be closed :D