fix(deps): Update dependencies (Kotlin 1.6) #521
Conversation
|
BTW @Filmaluco, have you tested this branch along with the other PRs for the gateway and ping? |
No. Courier is the one I have not tested. I plan on doing that today |
|
@gnarea just made the final test on Courier with Ping and Gateway, everything is working :) |
app/src/test/java/tech/relaycorp/cogrpc/server/CogRPCServerCollectCargoTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@Filmaluco, now that CI is working again it's reporting an issue with AppTest.
gnarea
changed the title
Filmaluco
force-pushed
the
update_dependencies
branch
2 times, most recently
from
2dbef33 to
5e395f1
Compare
|
@Filmaluco, I just noticed that the instrumentation test is failing on Android 6, not 8 (I thought API 23 = Android 8 🤦🏾♂️). I don't have a physical Android 6 device (I only have 5, 8, 11 and 12). I just pushed a change to use a physical Nexus 5 (Android 6) instead of the virtual one we've been using. If that still fails for the same reason, please go ahead and disable the test on Android 6 as discussed on Slack. Also, can you please undo the changes you made to try to make the test work on Firebase Test Lab? There are 2-3 things that appear to be attempts to make the test pass but have no effect. On that note, I noticed you introduced some changes to the Gradle config related to Orchestrator but you didn't enable the Orchestrator in |
|
The physical Nexus 5 didn't fix the issue :( I'm going to make one more attempt with a non-Nexus device on API 23 and if that doesn't fix it, then let's definitely disable the test on API 23. On the other hand, more bad news: I discovered that Firebase Test Lab wasn't actually running the tests on Android 5, so I fixed it in master (#532) but this branch is causing the app to crash before the tests run. Can you please look into it? Don't spend too much time on this because I can actually run the same APK on a physical Nexus 4 (Android 5) with no issues whatsoever... So if we can't get to the bottom of this issue within an hour or so, we should just disable Android 5 on Firebase Test Lab. |
updated: gradle tool version fixed: lint fixed: mockito issues fixed: data extraction rules && added: lint commentary fixed: room version fixed: issue with gradle tool update updated: removed unwanted maven repository updated: PR(#521) feedback fixed: issue with spotless ktlint version chore: Empty commit to trigger CI chore: Another empty commit to trigger CI chore(CI): Upgrade to Java 11 chore(CI): Use PR title validator from shared workflows fixed: deprecated sendBlocking methods now use trySendBlocking fixed: spotless check issues fixed: issue with coroutines scope changes
…ceptor testing firebase CI on api 23 added: protobuf has dependency to keep same version has grpc update: update awala cogrpc to java 11 updated: removed io.grpc:grpc dependency updated: added io.grpc:grpc dependency back
sdsantos
force-pushed
the
update_dependencies
branch
from
cf729fb to
db2950e
Compare
|
@gnarea talked with @Filmaluco and dropped all changes after bumping cogrpc |
Investigated for a bit. The issue is reproducible locally, but there aren't many clues to go on. We only get an easy-to-miss log message: |
There was a problem hiding this comment.
Thanks @sdsantos! Sorry, I missed your reply 😬
Sounds good. So now I'm going to:
- Remove Android 5 and 6 from the test matrix on Firebase Test Lab.
- Create an issue to try to make it work again in the future.
- Fix the GitHub checks in CI because there's a required check that's blocking this PR, but it shouldn't be.
Then I'll merge this PR.
gnarea
added
automerge
|
🎉 This PR is included in version 1.4.15 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.