Added codesign and resources #1069
Merged
+123
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for Windows: rehlds/.github#30 and rehlds/.github#29 - for Linux: rehlds/.github#28
stamepicmorg
added
Priority: ⚠️ medium
|
Tip We collectively came to the conclusion that signing each file inside the archive with .asc files is a bit redundant. For now, we'll just leave the signatures of the final archive and the native Windows ones. |
stamepicmorg
force-pushed
the
feature/codesign
branch
from
2b653aa to
a0c03e9
Compare
stamepicmorg
requested review from
SergeyShorokhov and
s1lentq
and removed request for
s1lentq and
SergeyShorokhov
SergeyShorokhov
approved these changes
Dec 22, 2024
SergeyShorokhov
requested review from
s1lentq
and removed request for
s1lentq
SergeyShorokhov
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added signing of windows binaries, resolves Add signing of windows binaries .github#30
Added resource metainfo to windows binaries, resolves Add resource metainfo to windows binaries .github#29
Added signing for linux binaries, resolves Add signing for linux binaries .github#28
Caution
This is
infrastructureupdate! NO code and NO bugfixes was implemented atReHLDSat this PR.Also, I know that we have .rc files that are used to create binaries.
The problem is that we have not yet fully decided how their future will develop from a development point of view. Also, now there are only 2 .rc files that are built into hlds.exe and hltv.exe. All other dlls are built naked, which excites antiviruses.
For now, I have chosen to use rcedit, written by the Electron project, which can successfully read and edit resources in compiled files. Which is what I am actually doing.
For now, I suggest leaving it as is. To launch the mechanism. And optimize it in subsequent iterations of development, to move the progress forward a little.